Page MenuHomePhabricator

Provide a way of having a meaningful slot header
Open, NormalPublic

Description

The following code is from ParserOutput::getText()

		// Hydrate slot section header placeholders generated by RevisionRenderer.
		$text = preg_replace_callback(
			'#<mw:slotheader>(.*?)</mw:slotheader>#',
			function ( $m ) {
				$role = htmlspecialchars_decode( $m[1] );
				// TODO: map to message, using the interface language. Set lang="xyz" accordingly.
				$headerText = $role;
				return $headerText;
			},
			$text
		);

The TODO needs to be implemented so that a slot can have a meaningful header on a page (rather than just the name of the slot role).

For the purposes of SDoC a plain text msg (without params) is adequate

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
OpenNone
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolveddaniel
Resolveddaniel
OpenNone

Event Timeline

Cparle created this task.Sep 25 2018, 2:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2018, 2:58 PM

Note that there are workarounds for this in WikibaseMediaInfoHooks.php in the WikibaseMediaInfo extension. They're clearly marked, and can probably be removed when this is done

daniel claimed this task.Dec 18 2018, 3:56 PM
CCicalese_WMF triaged this task as Normal priority.Dec 18 2018, 3:56 PM
daniel removed daniel as the assignee of this task.Jan 23 2019, 9:32 AM
daniel added a subscriber: daniel.
greg added a project: Multimedia.Mar 7 2019, 10:59 PM
WDoranWMF moved this task from MCR to mop on the Core Platform Team board.Jul 26 2019, 6:40 PM