The fatalmonitor shows:
Undefined variable: returntoquery in /srv/mediawiki/php-1.32.0-wmf.23/skins/MinervaNeue/includes/skins/SkinMinerva.php on line 701
error.
The $returntoquery variable is created only when a request wasn't POSTed, but the variable is accessed both on POST and non-POST requests. Please move the $returntoquery variable creation to top of SkinMinerva::insertLogInOutMenuItem() function.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | zeljkofilipin | T191069 1.32.0-wmf.23 deployment blockers | ||
| Resolved | PRODUCTION ERROR | None | T205449 SkinMinerva.php file logs "Undefined variable: returntoquery` error |
Change 462749 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Create $returntoquery variable properly
Presumably, this one is related as well. I'll map it to the same task for now.
PHP Warning: Invalid argument supplied for foreach() #1 /srv/mediawiki/php-1.32.0-wmf.23/skins/MinervaNeue/includes/skins/SkinMinerva.php(701): wfArrayToCgi(NULL) #2 /srv/mediawiki/php-1.32.0-wmf.23/skins/MinervaNeue/includes/skins/SkinMinerva.php(543): SkinMinerva->insertLogInOutMenuItem(MediaWiki\Minerva\MenuBuilder) #3 /srv/mediawiki/php-1.32.0-wmf.23/skins/MinervaNeue/includes/skins/SkinMinerva.php(560): SkinMinerva->buildPersonalTools(MediaWiki\Minerva\MenuBuilder)
# line 701 $query[ 'returntoquery' ] = wfArrayToCgi( $returntoquery );
BTW, I found what's causing this issue, and it's pretty magical, PHP magic. The error was introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/461848/
The variable $returntoquery didn't exist in the else{} statement, but because we were setting $returntoquery[ 'welcome' ] = 'yes' PHP magically was creating that variable under the hood. Because we removed setting the welcome key, the variable wasn't defined, and because that it stopped working.
Change 462749 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Create $returntoquery variable properly
Change 463087 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@wmf/1.32.0-wmf.23] Create $returntoquery variable properly
Change 463087 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.32.0-wmf.23] Create $returntoquery variable properly
Mentioned in SAL (#wikimedia-operations) [2018-09-26T15:29:39Z] <pmiazga@deploy1001> Synchronized php-1.32.0-wmf.23/skins/MinervaNeue/includes/skins/SkinMinerva.php: SWAT: [[gerrit:463087|Create $returntoquery variable properly(T205449)]] (duration: 00m 56s)