Maniphest T205464

Flaky unit test "DerivedPageDataUpdaterTest::testGetPreparedEditAfterPrepareUpdate"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Seen again recently on Travis CI:

https://travis-ci.org/wikimedia/mediawiki/jobs/433020634

1) MediaWiki\Tests\Storage\DerivedPageDataUpdaterTest::testGetPreparedEditAfterPrepareUpdate
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'20180925161827'
+'20180925161826'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/DerivedPageDataUpdaterTest.php:487

Looks like there's some non-explicit assumption in this test based on a variable timestamp.

Recent changes:

Details

	Subject	Repo	Branch	Lines +/-
	ParserOutput::getCacheTime should stay the same after the first call.	mediawiki/core	master	+65 -7

Customize query in gerrit

Related Objects

Mentioned Here: rMWe8632ab0f626: [MCR] Factor PageUpdater out of WikiPage
rMW7960d5385f11: Introduce ContentHandler::getSecondaryDataUpdates.
T174038: Initial implementation of MCR page update interface
T194038: Introduce ContentHandler::getSecondaryDataUpdates to replace Content::getSecondaryDataUpdates

Event Timeline

Krinkle created this task.Sep 25 2018, 5:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2018, 5:49 PM

CCicalese_WMF added projects: Platform Engineering (MCR: Reactive), Platform Team Legacy (Next).Oct 3 2018, 7:11 PM

CCicalese_WMF moved this task from Inbox to Next on the Multi-Content-Revisions board.

daniel claimed this task.Oct 4 2018, 10:10 AM

daniel triaged this task as High priority.

daniel moved this task from Next to In Progress on the Multi-Content-Revisions board.

Change 464508 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] ParserOutput::getCacheTime should stay the same after the first call.

https://gerrit.wikimedia.org/r/464508

gerritbot added a project: Patch-For-Review.Oct 4 2018, 10:34 AM

daniel edited projects, added Platform Team Legacy (Designing); removed Platform Team Legacy (Next).Oct 4 2018, 10:36 AM

daniel added a project: MediaWiki-libs-BagOStuff.

CCicalese_WMF moved this task from In Progress to Reactive on the Multi-Content-Revisions board.Oct 4 2018, 2:57 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (Reactive); removed Multi-Content-Revisions.

CCicalese_WMF moved this task from MCR: Reactive to MCR on the Platform Engineering board.Oct 4 2018, 3:14 PM

CCicalese_WMF edited projects, added Platform Engineering (MCR); removed Platform Engineering (MCR: Reactive).

CCicalese_WMF moved this task from Inbox to Waiting for Review on the Platform Team Legacy (Designing) board.Oct 4 2018, 3:22 PM

Change 464508 merged by jenkins-bot:
[mediawiki/core@master] ParserOutput::getCacheTime should stay the same after the first call.

https://gerrit.wikimedia.org/r/464508

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 4 2018, 5:01 PM