Page MenuHomePhabricator

Flaky unit test "DerivedPageDataUpdaterTest::testGetPreparedEditAfterPrepareUpdate"
Closed, ResolvedPublic

Description

Seen again recently on Travis CI:

https://travis-ci.org/wikimedia/mediawiki/jobs/433020634

1) MediaWiki\Tests\Storage\DerivedPageDataUpdaterTest::testGetPreparedEditAfterPrepareUpdate
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'20180925161827'
+'20180925161826'
/home/travis/build/wikimedia/mediawiki/tests/phpunit/includes/Storage/DerivedPageDataUpdaterTest.php:487

Looks like there's some non-explicit assumption in this test based on a variable timestamp.

Recent changes:

Event Timeline

Krinkle created this task.Sep 25 2018, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2018, 5:49 PM
daniel claimed this task.Oct 4 2018, 10:10 AM
daniel triaged this task as High priority.
daniel moved this task from Next to In Progress on the Multi-Content-Revisions board.

Change 464508 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] ParserOutput::getCacheTime should stay the same after the first call.

https://gerrit.wikimedia.org/r/464508

Change 464508 merged by jenkins-bot:
[mediawiki/core@master] ParserOutput::getCacheTime should stay the same after the first call.

https://gerrit.wikimedia.org/r/464508

daniel closed this task as Resolved.Oct 4 2018, 5:35 PM