Page MenuHomePhabricator
Create Task
Maniphest T205491

QuoteTransformer and quote-tokens use a ".value" property on the token instead of adding it to the token's attributes
Closed, ResolvedPublic
Actions

Description

The PEG tokenizer adds a quote token's string value as a ".value" attribute after-the-fact instead of stuffing it as an attribute of the token.
Consequently, the QuoteTransformer uses ".value" instead of token.getAttribute('value').
Presumably, this was either an oversight or a premature performance optimization (see T205479: Fix token datastructure to fix potential perfomance issue).

This should be fixed.

Details

ProjectBranchLines +/-Subject
mediawiki/services/parsoidmaster+14 K -12 KQuoteTransformer quote tokens don't need to be special snowflakes
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Sep 25 2018, 8:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2018, 8:52 PM
ssastry triaged this task as Medium priority.Sep 25 2018, 8:53 PM
ssastry moved this task from Backlog to Parsoid Fixes on the Parsoid-PHP board.
ssastry assigned this task to Sbailey.Nov 20 2018, 2:51 PM
ssastry claimed this task.Dec 18 2018, 5:37 PM
ssastry added a subscriber: Sbailey.
gerritbot added a subscriber: gerritbot.Dec 18 2018, 5:52 PM

Change 480552 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] QuoteTransformer quote tokens don't need to be special snowflakes

https://gerrit.wikimedia.org/r/480552

gerritbot added a project: Patch-For-Review.Dec 18 2018, 5:52 PM
gerritbot added a comment.Dec 18 2018, 8:48 PM

Change 480552 merged by jenkins-bot:
[mediawiki/services/parsoid@master] QuoteTransformer quote tokens don't need to be special snowflakes

https://gerrit.wikimedia.org/r/480552

ssastry closed this task as Resolved.Dec 18 2018, 8:50 PM
Stashbot mentioned this in T197616: Create a production test wiki in group0 to parallel Wikimedia Commons.Jan 8 2019, 7:11 PM
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2019-01-08T19:11:39Z] <arlolra> Updated Parsoid to 2c5dc7b (T197616, T205491, T209772, T199926, T209194, T204622)

Stashbot mentioned this in T209772: visitDOM makes an invalid assumption about its handlers.Jan 8 2019, 7:11 PM
Stashbot mentioned this in T199926: html -> wt: Parsoid sometimes trips up on | chars in hrefs.
Stashbot mentioned this in T209194: Export one "real" ES6 class per file.
Stashbot mentioned this in T204622: Use native Javascript (ES6) classes instead of prototype-based definition pattern in the Parsoid codebase.
ssastry mentioned this in T215638: List tokens use special-cased "bullets" property instead of stuffing it in attribs like other tokens.Feb 8 2019, 5:49 PM
Aklapper removed a project: Patch-For-Review.Apr 10 2020, 9:43 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL