Page MenuHomePhabricator

Delay the display of error message when gloss language is wrong
Closed, ResolvedPublic3 Estimated Story Points


Following T198203, now when a gloss language code is incorrect, the "Publish" button is blocked and an error message appears.
This behaviour is correct, but when I start typing a language code, for example "fr", as soon as I type the "f", the field immediately gets red, the error message appears, and that's confusing, since I didn't finish typing the code.

Screenshot from 2018-09-26 13-12-11.png (209×897 px, 13 KB)

Ideally, we would have a solution to keep blocking the save button and warning the user, while letting them the time to type the language code quietly.

Here's what I suggest:

  • keep the Publish button blocked as long as the language code is incorrect
  • wait 5 seconds and check again before displaying the error message and coloring the field in red

Event Timeline

An alternative approach would be to listen for [change]( events instead of for [input]( events: change only fires when the change “is committed by the user”, e. g. when the input field loses focus. But I have no idea if that’s possible to do with Vue.js.

Change 464008 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Check gloss language on change and not on input

Change 464008 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Check gloss language on change and not on input