Maniphest T205566

Paypal Orphan Slayer Missing PayerID
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• mepps
	Sep 26 2018, 6:31 PM

Description

I saw in the logs today that the missing PayerID is causing an error to be returned. This needs more investigation.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Stop processing when PaymentActionNotInitiated	mediawiki/extensions/DonationInterface	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned In: T239756: Investigate why orphan-slayer job is running for hours

Event Timeline

• mepps created this task.Sep 26 2018, 6:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2018, 6:31 PM

• DStrine moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.Oct 1 2018, 7:40 PM

• DStrine moved this task from Sprint +3 to Q3 2021-2022 on the Fundraising-Backlog board.May 6 2019, 9:38 PM

@DStrine let's prioritize this - it looks like we can fix this without too much work, and it might let us complete a bunch more dangling PayPal transactions.

Tech details:
When the GetExpressCheckoutDetails API call comes back with CHECKOUTSTATUS=PaymentActionNotInitiated, that means the donor never did the payment on the paypal side, and we should just stop there and delete the pending row. Instead, we're barrelling through and calling DoExpressCheckoutPayment without the proper parameters. This wastes about a second per dangling transaction. Looks like 10x as many pending PayPal rows are NotInitiated as are resolvable, so these seconds will add up.

• DStrine moved this task from Q3 2021-2022 to Sprint +1 on the Fundraising-Backlog board.Dec 6 2021, 11:02 PM

Ejegg mentioned this in T239756: Investigate why orphan-slayer job is running for hours.Dec 6 2021, 11:24 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Dec 7 2021, 9:22 PM

• DStrine added a project: Fundraising Sprint Xenomorph Petting Zoo.Dec 7 2021, 9:33 PM

• DStrine triaged this task as Medium priority.Dec 8 2021, 5:02 PM

Change 747648 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Stop processing when PaymentActionNotInitiated

https://gerrit.wikimedia.org/r/747648

gerritbot added a project: Patch-For-Review.Dec 16 2021, 12:40 AM

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Xenomorph Petting Zoo board.Dec 16 2021, 12:40 AM

• DStrine added a project: fundraising sprint Yeet-coaster.Dec 21 2021, 9:11 PM

Ejegg moved this task from Backlog to Review on the fundraising sprint Yeet-coaster board.Dec 23 2021, 1:56 AM