Error
Request ID: W6vXEgrAIDwAAHfqD8MAAAAS
Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $dbkey: invalid DB key 'FeedItem/potd/20180917000000/nl_'
#0 /srv/mediawiki/php-1.32.0-wmf.23/includes/title/TitleValue.php(105): Wikimedia\Assert\Assert::parameter(boolean, string, string) #1 /srv/mediawiki/php-1.32.0-wmf.23/includes/specialpage/SpecialPage.php(101): TitleValue->__construct(integer, string, string) #2 /srv/mediawiki/php-1.32.0-wmf.23/includes/specialpage/SpecialPage.php(85): SpecialPage::getTitleValueFor(string, string, string) #3 /srv/mediawiki/php-1.32.0-wmf.23/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php(179): SpecialPage::getTitleFor(string, string) #4 /srv/mediawiki/php-1.32.0-wmf.23/extensions/FeaturedFeeds/includes/FeaturedFeedChannel.php(136): FeaturedFeedChannel->getFeedItem(integer) #5 /srv/mediawiki/php-1.32.0-wmf.23/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(185): FeaturedFeedChannel->getFeedItems() #6 /srv/mediawiki/php-1.32.0-wmf.23/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(34): FeaturedFeeds::getFeedsInternal(string) #7 /srv/mediawiki/php-1.32.0-wmf.23/extensions/FeaturedFeeds/includes/FeaturedFeeds.php(97): FeaturedFeeds::getFeeds(string) #8 /srv/mediawiki/php-1.32.0-wmf.23/includes/Hooks.php(174): FeaturedFeeds::beforePageDisplay(OutputPage, SkinVector) #9 /srv/mediawiki/php-1.32.0-wmf.23/includes/Hooks.php(234): Hooks::callHook(string, array, array, NULL, string) #10 /srv/mediawiki/php-1.32.0-wmf.23/includes/OutputPage.php(2450): Hooks::runWithoutAbort(string, array) #11 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(875): OutputPage->output(boolean) #12 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(887): Closure$MediaWiki::main() #13 /srv/mediawiki/php-1.32.0-wmf.23/includes/MediaWiki.php(525): MediaWiki->main() #14 /srv/mediawiki/php-1.32.0-wmf.23/index.php(42): MediaWiki->run()
Notes
This is showing up in the logs starting Sept 19 (1.32.0-wmf.20). While the problematic code is deployed on many wikis, it has currently only been triggered by users on commons.wikimedia.org.
The users in question were viewing the Commons main page, at https://commons.wikimedia.org/wiki/Main_Page. Just plainly, without any query parameters.
Viewing that url, the exception does not happen for me. So this must be dependant on some kind of cookie or user preference.
However, I'm able to consistently trigger it via https://commons.wikimedia.org/wiki/Main_Page?uselang=nl_.
As such, there are two problems here:
- We have a fatal error exposed on a public GET url. This is a risk can that cause false alarms.
- Somehow, our preferences system, or ULS, has likely caused some users to have an invalid language code of nl_ saved as their language code. Which works surprisingly fine on most pages, except pages that use FeaturedFeeds, in which case it gets a fatal error.