Maniphest T205582

It should be possible to count errors via statsv in production
Closed, ResolvedPublic3 Story Points
Actions

Description

We added MinervaErrorLogSamplingRate to allow error logging via EventLogging, however per discussion in T203814 we have decided to only turn this on on the beta cluster.

However, it's important for us to know and be able to report on the number of errors.

To do this, we should safely use statsv

Acceptance criteria

Every time there is an error
As always this is feature flagged and set to false by default.
Configuring wgMinervaErrorLogSamplingRate has no impact on statsv error counting.
Verify that errors are counted properly beta cluster.

Developer notes

Update resources/skins.minerva.scripts/errorLogging.js handleError method so that a statsv counter is updated on every error when initialised.

For example:

mw.track( 'counter.MediaWiki.MinervaClientError', 1 ); // increment

Related Objects
Search...

Status	Assigned	Task
Open	None	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195475 [EPIC] Automate asset bundling in MobileFrontend
Resolved	Jdlrobson	T166905 [EPIC] Talk about and improve our frontend code architecture
Open	None	T106915 Use Sentry in production
Resolved	Jdlrobson	T167699 [EPIC] Enable JS error reporting in the mobile website
Resolved	nray	T205582 It should be possible to count errors via statsv in production

Event Timeline

Jdlrobson created this task.Sep 26 2018, 9:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2018, 9:05 PM

Jdlrobson mentioned this in T203814: Turn on MinervaErrorLogSamplingRate (Schema:WebClientError).Sep 26 2018, 9:05 PM

Jdlrobson added a parent task: T167699: [EPIC] Enable JS error reporting in the mobile website.

Jdlrobson triaged this task as Normal priority.Sep 26 2018, 11:14 PM

Niedzielski awarded a token.Oct 2 2018, 1:26 PM

ovasileva set the point value for this task to 3.Oct 2 2018, 4:12 PM

Jdlrobson raised the priority of this task from Normal to High.Oct 3 2018, 8:46 PM

Jdlrobson mentioned this in T205128: Bundle Hogan.js.

^ @ovasileva ready to work on, smallish and seems more important than other items in todo with equal complexity (3 points). lemme know if you disagree.

In T205582#4640052, @Jdlrobson wrote:

^ @ovasileva ready to work on, smallish and seems more important than other items in todo with equal complexity (3 points). lemme know if you disagree.

sounds good

Jdlrobson moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 4 2018, 9:28 PM

Change 464723 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Errors can be counted in statsv

https://gerrit.wikimedia.org/r/464723

gerritbot added a project: Patch-For-Review.Oct 4 2018, 9:33 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 4 2018, 9:33 PM

https://grafana.wikimedia.org/dashboard/db/reading-web-dashboard?orgId=1&panelId=15&fullscreen&edit&tab=general and https://grafana-labs-admin.wikimedia.org/dashboard/db/reading-web-beta-dashboard?orgId=1&panelId=7&fullscreen verify this is working.

Piotr will review today

pmiazga moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 8 2018, 8:43 PM

Change 465284 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[operations/mediawiki-config@master] Beta: enable errors counting via statsv by Minerva skin

https://gerrit.wikimedia.org/r/465284

Change 465284 merged by jenkins-bot:
[operations/mediawiki-config@master] Beta: enable errors counting via statsv by Minerva skin

https://gerrit.wikimedia.org/r/465284

pmiazga updated the task description. (Show Details)Oct 8 2018, 9:43 PM

Jdlrobson mentioned this in T204143: ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't.Oct 8 2018, 10:28 PM

Change 464723 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Errors can be counted in statsv

https://gerrit.wikimedia.org/r/464723

nray claimed this task.Oct 8 2018, 10:37 PM

nray added a subscriber: pmiazga.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 8 2018, 11:00 PM

Jdlrobson mentioned this in T206702: Enable client side error counting on Minerva production (wikipedia only).Oct 10 2018, 9:04 PM

nray closed this task as Resolved.Oct 12 2018, 3:42 PM

nray updated the task description. (Show Details)

Change 467984 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Hygiene: Track minerva errors count only once

https://gerrit.wikimedia.org/r/467984

pmiazga added a comment.Oct 17 2018, 5:10 PM

This comment was removed by pmiazga.

phuedx mentioned this in T217142: [WIP] [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.Feb 27 2019, 2:20 PM

It should be possible to count errors via statsv in productionClosed, ResolvedPublic3 Story PointsActions