Page MenuHomePhabricator
Create Task
Maniphest T205593

Webpack: Skins and Overlay management
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Continue the migration of mobile.startup to webpack.

Acceptance criteria

  • Anchor built via webpack
  • Skin built via webpack and tested by node-qunit
  • OverlayManager built via webpack and tested by node-qunit
  • Overlay built via webpack and tested by node-qunit
  • LoadingOverlay built via webpack and tested by node-qunit
  • rlModuleLoader built via webpack and tested by node-qunit

Note: Adding additional test coverage is out of scope and will be added separately.
Note: If tests cannot be ported (similar to View.js) create tasks and leave them be. Only port the trivial tests.

Sign off steps

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+7 -7Remove extraneous line in templateReader.js comment + add spaces
mediawiki/extensions/MobileFrontendmaster+40 -39Migrate LoadingOverlay.js to webpack
mediawiki/extensions/MobileFrontendmaster+53 -55Migrate rlModuleLoader.js to webpack
mediawiki/extensions/MobileFrontendmaster+403 -401Migrate Overlay.js to webpack
mediawiki/extensions/MobileFrontendmaster+589 -561Migrate OverlayManager.js to webpack
mediawiki/extensions/MobileFrontendmaster+602 -577Migrate Skin.js to webpack
mediawiki/extensions/MobileFrontendmaster+104 -1Add templateReader.js utility function
mediawiki/extensions/MobileFrontendmaster+62 -61Migrate Anchor.js to webpack
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 26 2018, 11:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2018, 11:16 PM
Jdlrobson added a project: MobileFrontend (MobileFrontend and MinervaNeue architecture).Oct 1 2018, 6:53 PM
ovasileva triaged this task as High priority.Oct 2 2018, 4:21 PM
ovasileva set the point value for this task to 3.Oct 2 2018, 4:25 PM
Jdlrobson updated the task description. (Show Details)Oct 2 2018, 4:26 PM
Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Readers-Web-Backlog board.Oct 5 2018, 5:47 PM
Jdlrobson edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
Jdlrobson updated the task description. (Show Details)Oct 9 2018, 4:50 PM

Added Anchor.js. It has no tests. We can re-estimate if necessary but I don't think it should impact the estimation here.

nray claimed this task.Oct 9 2018, 5:50 PM
nray moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
gerritbot added a subscriber: gerritbot.Oct 11 2018, 3:39 PM

Change 466666 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate Anchor.js to webpack

https://gerrit.wikimedia.org/r/466666

gerritbot added a project: Patch-For-Review.Oct 11 2018, 3:39 PM

Change 466667 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate Skin.js to webpack

https://gerrit.wikimedia.org/r/466667

gerritbot added a comment.Oct 11 2018, 3:40 PM

Change 466668 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate OverlayManager.js to webpack

https://gerrit.wikimedia.org/r/466668

gerritbot added a comment.Oct 11 2018, 3:40 PM

Change 466669 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate Overlay.js to webpack

https://gerrit.wikimedia.org/r/466669

gerritbot added a comment.Oct 11 2018, 3:40 PM

Change 466670 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate LoadingOverlay.js to webpack

https://gerrit.wikimedia.org/r/466670

gerritbot added a comment.Oct 11 2018, 3:40 PM

Change 466671 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate rlModuleLoader.js to webpack

https://gerrit.wikimedia.org/r/466671

gerritbot added a comment.Oct 11 2018, 10:25 PM

Change 466666 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate Anchor.js to webpack

https://gerrit.wikimedia.org/r/466666

gerritbot added a comment.Oct 16 2018, 6:15 PM

Change 467747 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Add templateReader.js utility function

https://gerrit.wikimedia.org/r/467747

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 16 2018, 10:04 PM
gerritbot added a comment.Oct 17 2018, 9:51 PM

Change 467747 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add templateReader.js utility function

https://gerrit.wikimedia.org/r/467747

gerritbot added a comment.Oct 17 2018, 9:56 PM

Change 466667 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Migrate Skin.js to webpack

https://gerrit.wikimedia.org/r/466667

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 17 2018, 10:00 PM
nray mentioned this in T207341: Migrate Overlay.test.js to tests/node-qunit/mobile.startup.Oct 17 2018, 10:29 PM
gerritbot added a comment.Oct 17 2018, 10:31 PM

Change 466668 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Migrate OverlayManager.js to webpack

https://gerrit.wikimedia.org/r/466668

nray added a comment.EditedOct 17 2018, 10:32 PM

Per the task's instructions to 'Only port the trivial tests', Overlay's test files are to be done in T207341 due to its dependence on mw.template.get

gerritbot added a comment.Oct 17 2018, 10:45 PM

Change 466669 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate Overlay.js to webpack

https://gerrit.wikimedia.org/r/466669

gerritbot added a comment.Oct 17 2018, 10:50 PM

Change 466670 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate LoadingOverlay.js to webpack

https://gerrit.wikimedia.org/r/466670

gerritbot added a comment.Oct 17 2018, 10:59 PM

Change 466671 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate rlModuleLoader.js to webpack

https://gerrit.wikimedia.org/r/466671

gerritbot added a comment.Oct 17 2018, 11:11 PM

Change 468181 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Remove extraneous line in templateReader.js comment + add space

https://gerrit.wikimedia.org/r/468181

gerritbot added a comment.Oct 17 2018, 11:34 PM

Change 468181 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove extraneous line in templateReader.js comment + add spaces

https://gerrit.wikimedia.org/r/468181

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 12:07 AM
nray removed nray as the assignee of this task.Oct 18 2018, 12:08 AM
nray added a subscriber: nray.
Jdlrobson closed this task as Resolved.Oct 18 2018, 12:23 AM
Jdlrobson updated the task description. (Show Details)

https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFrontend_%26_MinervaNeue_frontend_architecture/Progress?useskin=vector has been updated.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL