Page MenuHomePhabricator

NWE+CodeMirror: Notice about unflagged revision can cause different line breaks
Open, Needs TriagePublic

Description

Steps to reproduce:

  1. Go to https://de.wikipedia.beta.wmflabs.org/wiki/1._M%C3%BCnchner_SC?veaction=editsource
  2. If that's not already the case, make your window small enough that the notice "Nicht markiert" in the top right corner overlaps the text to edit.

Expected result: Actually, the notice should not overlap at all, but at least it shouldn't mess up position of syntaxhighlighting.

Actual result:

Note that the syntaxhightlight and the actual text now differ, as visible in the red underline for "SC", which is one line to low.

Event Timeline

Schnark created this task.Sep 28 2018, 9:02 AM
Restricted Application added projects: VisualEditor, Community-Tech. · View Herald TranscriptSep 28 2018, 9:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Cirdan added a subscriber: Cirdan.Sep 28 2018, 10:24 AM
Esanders added a subscriber: Esanders.EditedSep 30 2018, 11:25 AM

It would be better if FlaggedRevs didn't encroach on the content area, like other page status indicators.

VE should also be able guard against bad behaviour like this using clear:both.

JTannerWMF moved this task from To Triage to Freezer on the VisualEditor board.Mar 27 2019, 6:27 PM