Page MenuHomePhabricator
Create Task
Maniphest T205703

Special:ConfirmEmail should give username when logged in as other user
Open, Needs TriagePublic
Actions

Description

If you click an email confirmation link to https://en.wikipedia.org/wiki/Special:ConfirmEmail while logged in then you get https://en.wikipedia.org/wiki/MediaWiki:Confirmemail_loggedin:
"Your email address has now been confirmed."

The email gives the username but Special:ConfirmEmail does not. While making email confirmation for PrimeHunter3, I was logged in as PrimeHunter and got a page saying "Your email address has now been confirmed." It's a confusing wording when it does not refer to your logged in account. I suggest Special:ConfirmEmail gives the username in this situation. Something like "The email address for USERNAME has now been confirmed."

If you are not logged in then you get https://en.wikipedia.org/wiki/MediaWiki:Confirmemail_success:
"Your email address has been confirmed. You may now log in and enjoy the wiki."

It would also be OK to always give the username.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Special:ConfirmEmail should give username when logged in as other usermediawiki/coremaster+7 -5
Customize query in gerrit

Event Timeline

PrimeHunter created this task.Sep 28 2018, 11:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2018, 11:41 AM
gerritbot added a comment.Jan 9 2020, 7:14 PM

Change 563160 had a related patch set uploaded (by InturiBhargav; owner: InturiBhargav):
[mediawiki/core@master] Special:ConfirmEmail should give username when logged in as other user

https://gerrit.wikimedia.org/r/563160

gerritbot added a project: Patch-For-Review.Jan 9 2020, 7:14 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Mar 22 2022, 12:32 PM
gerritbot added a comment.Mon, Mar 30, 1:20 PM

Change #563160 abandoned by Hashar:

[mediawiki/core@master] Special:ConfirmEmail should give username when logged in as other user

https://gerrit.wikimedia.org/r/563160

gerritbot added a comment.Mon, Mar 30, 11:26 PM

Change #563160 restored by Thcipriani:

[mediawiki/core@master] Special:ConfirmEmail should give username when logged in as other user

https://gerrit.wikimedia.org/r/563160

gerritbot added a project: Patch-For-Review.Mon, Mar 30, 11:26 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMon, Mar 30, 11:26 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Tue, Mar 31, 1:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits