Page MenuHomePhabricator

parse.js genTest mode emits COMMENT instead of CommentTk
Closed, ResolvedPublic

Description

genTest output is emitting incorrect token type for comments.

This then triggers an assertion in transformTests.js runner

Event Timeline

ssastry created this task.Sep 28 2018, 7:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2018, 7:55 PM
ssastry triaged this task as High priority.Sep 28 2018, 7:55 PM
ssastry reopened this task as Open.Sep 28 2018, 10:39 PM

No. That only dealt with the "hardcoded" unit tests and consumption of those tests .. not generation of those test files.

Change 464426 had a related patch set uploaded (by Subramanya Sastry; owner: Sbailey):
[mediawiki/services/parsoid@master] Replaced token type 'COMMENT' with 'CommentTk'

https://gerrit.wikimedia.org/r/464426

Change 464426 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Replaced token type 'COMMENT' with 'CommentTk'

https://gerrit.wikimedia.org/r/464426

ssastry closed this task as Resolved.Oct 11 2018, 6:09 PM
ssastry removed a project: Patch-For-Review.