Page MenuHomePhabricator
Create Task
Maniphest T205743

parse.js genTest mode emits COMMENT instead of CommentTk
Closed, ResolvedPublic
Actions

Description

genTest output is emitting incorrect token type for comments.

This then triggers an assertion in transformTests.js runner

Details

ProjectBranchLines +/-Subject
mediawiki/services/parsoidmaster+1 -1Replaced token type 'COMMENT' with 'CommentTk'
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Sep 28 2018, 7:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2018, 7:55 PM
ssastry triaged this task as High priority.Sep 28 2018, 7:55 PM
Arlolra closed this task as Resolved.Sep 28 2018, 10:36 PM
Arlolra added a subscriber: Arlolra.

Presumably this is fixed by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/461708

ssastry reopened this task as Open.Sep 28 2018, 10:39 PM
In T205743#4626649, @Arlolra wrote:

Presumably this is fixed by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/461708

No. That only dealt with the "hardcoded" unit tests and consumption of those tests .. not generation of those test files.

gerritbot added a subscriber: gerritbot.Oct 3 2018, 9:03 PM

Change 464426 had a related patch set uploaded (by Subramanya Sastry; owner: Sbailey):
[mediawiki/services/parsoid@master] Replaced token type 'COMMENT' with 'CommentTk'

https://gerrit.wikimedia.org/r/464426

gerritbot added a project: Patch-For-Review.Oct 3 2018, 9:03 PM
gerritbot added a comment.Oct 3 2018, 9:14 PM

Change 464426 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Replaced token type 'COMMENT' with 'CommentTk'

https://gerrit.wikimedia.org/r/464426

ssastry closed this task as Resolved.Oct 11 2018, 6:09 PM
ssastry removed a project: Patch-For-Review.
Stashbot mentioned this in T205642: Error a.k.toLowerCase is not a function parsing extension token.Oct 15 2018, 8:52 PM
Stashbot mentioned this in T206003: Beta Cluster: Parsoid config request failures from the MediaWiki API.
Stashbot mentioned this in T187848: Fix token transformer return types.
Stashbot mentioned this in T205455: transformTests.js fails to validate QuoteTransformer on a bunch of wiki pages.
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-10-15T20:52:25Z] <arlolra> Updated Parsoid to 8f3ff40 (T205642, T206003, T187848, T205455, T205743)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL