Page MenuHomePhabricator
Create Task
Maniphest T205796

Edit links in Special:DisambiguationPageLinks should only be shown if user can edit
Closed, ResolvedPublic
Actions

Description

This change will be very similar to https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/SpecialBrokenRedirects.php$129. It should check whether the user can edit (has the "edit" permission and isn't blocked) and whether the page will "accept" action=edit.

For performance, the following piece of code should also be added to SpecialDisambiguationPageLinks: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/SpecialBrokenRedirects.php$172.

The relevant method is [[ https://phabricator.wikimedia.org/diffusion/EDIS/browse/master/specials/SpecialDisambiguationPageLinks.php$71 | SpecialDisambiguationPageLinks::formatResult ]].

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Show edit links in Special:DisambiguationPageLinks only if user can editUrbanecmmediawiki/extensions/Disambiguatormaster+25 -7
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Sep 30 2018, 2:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2018, 2:03 PM
Urbanecm updated the task description. (Show Details)Sep 30 2018, 3:39 PM
gerritbot subscribed.Sep 30 2018, 3:59 PM

Change 463679 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/Disambiguator@master] Edit links in Special:DisambiguationPageLinks should only be shown if user can edit

https://gerrit.wikimedia.org/r/463679

gerritbot added a project: Patch-For-Review.Sep 30 2018, 3:59 PM
Urbanecm claimed this task.Sep 30 2018, 3:59 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptSep 30 2018, 3:59 PM
Urbanecm triaged this task as Low priority.Sep 30 2018, 4:00 PM
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Sep 30 2018, 4:06 PM
Urbanecm removed Urbanecm as the assignee of this task.May 24 2019, 8:28 PM
Urbanecm removed projects: User-Urbanecm, Patch-For-Review.
gerritbot added a comment.Jul 17 2019, 10:08 AM

Change 463679 had a related patch set uploaded (by Matěj Suchánek; owner: Urbanecm):
[mediawiki/extensions/Disambiguator@master] Show edit links in Special:DisambiguationPageLinks only if user can edit

https://gerrit.wikimedia.org/r/463679

gerritbot added a project: Patch-For-Review.Jul 17 2019, 10:08 AM
Umherirrender closed this task as Resolved.Oct 31 2019, 6:31 PM
Umherirrender assigned this task to Urbanecm.
gerritbot added a comment.Oct 31 2019, 6:35 PM

Change 463679 merged by jenkins-bot:
[mediawiki/extensions/Disambiguator@master] Show edit links in Special:DisambiguationPageLinks only if user can edit

https://gerrit.wikimedia.org/r/463679

Umherirrender mentioned this in rEDISf0bcb46c3bc7: Show edit links in Special:DisambiguationPageLinks only if user can edit.Oct 31 2019, 7:00 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 1 2019, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits