Page MenuHomePhabricator
Create Task
Maniphest T205807

Dialog actions are inconsistent in visual editor
Closed, ResolvedPublic
Actions

Description

Most editing dialogs have an "Apply changes" button, but some (the table dialog and extension dialogs) have "Done" instead. There's no obvious reason for this inconsistency.

Details

SubjectRepoBranchLines +/-
ve.ui.MWGraphDialog: don't redefine actionsmediawiki/extensions/Graphmaster+0 -20
Update VE core submodule to master (e9becf4d0)mediawiki/extensions/VisualEditormaster+1 -1
Make extension dialog done action messages match other dialogsmediawiki/extensions/VisualEditormaster+1 -1
Make table dialog done action message match other dialogsVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Sep 30 2018, 8:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2018, 8:12 PM
gerritbot subscribed.Sep 30 2018, 8:23 PM

Change 463688 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Make table dialog done action message match other dialogs

https://gerrit.wikimedia.org/r/463688

gerritbot added a project: Patch-For-Review.Sep 30 2018, 8:23 PM

Change 463689 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] Make extension dialog done action messages match other dialogs

https://gerrit.wikimedia.org/r/463689

Tchanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Sep 30 2018, 8:28 PM
gerritbot added a comment.Sep 30 2018, 8:36 PM

Change 463688 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make table dialog done action message match other dialogs

https://gerrit.wikimedia.org/r/463688

gerritbot added a comment.Sep 30 2018, 8:46 PM

Change 463689 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Make extension dialog done action messages match other dialogs

https://gerrit.wikimedia.org/r/463689

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Sep 30 2018, 9:00 PM
gerritbot added a comment.Oct 1 2018, 2:10 PM

Change 463765 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e9becf4d0)

https://gerrit.wikimedia.org/r/463765

gerritbot added a comment.Oct 1 2018, 2:55 PM

Change 463765 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e9becf4d0)

https://gerrit.wikimedia.org/r/463765

Tchanders moved this task from Code review to QA on the VisualEditor (Current work) board.Oct 2 2018, 11:38 AM
Ryasmeen subscribed.Oct 17 2018, 11:17 PM

@Tchanders: This patch is supposed to convert all "Done" buttons to "Apply changes" for all dialogs right? I am still seeing "Done" button for all extension dialogs. Or maybe I'm missing something..

Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.Oct 17 2018, 11:21 PM
JTannerWMF added a subscriber: • marcella.Oct 24 2018, 11:07 PM
Tchanders added a comment.EditedOct 29 2018, 3:07 PM

@Ryasmeen Is it possible you're looking at inspectors? The extension dialogs are graph, math[1], chem[1], maps, syntax highlight and pre. These and other dialogs should all have "Apply changes" - do you see those?

The inspectors still have "Done", which possibly makes more sense because with some of them the changes are applied as you make them (e.g. if you highlight a word and open the link inspector, the link styling is added straight away; when you open the math/chem/score inspectors, the formula/score updates as you type, while the inspector is still open). OTOH dialogs take over the page and any changes are only applied upon closing. (I'd be happy to discuss changing the labels on inspectors, but this task is just meant for the dialogs.)

[1] For math and chem, if you click on "Quick edit", it opens an inspector instead of a dialog.

• marcella moved this task from Stalled/Waiting to QA on the VisualEditor (Current work) board.Oct 30 2018, 3:15 PM
JTannerWMF added a project: Editing QA.Nov 6 2018, 5:28 PM
Esanders moved this task from Inbox to Low Priority on the Editing QA board.Nov 14 2018, 4:25 PM
Ryasmeen added a comment.Nov 14 2018, 11:46 PM

@Tchanders: I see, yeah I rechecked for the extension dialogs and all of them have "Apply changes" button except the one for Graph. It's still showing "Done" for me.

Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.Nov 14 2018, 11:47 PM
Ryasmeen removed a project: Editing QA.Nov 28 2018, 1:06 AM
• marcella removed Tchanders as the assignee of this task.Nov 28 2018, 3:11 PM
• marcella moved this task from Stalled/Waiting to Incoming on the VisualEditor (Current work) board.
Tchanders added a comment.Nov 28 2018, 3:43 PM

@Ryasmeen Oops looks like I forgot to push the change - thanks for pointing that out!

gerritbot added a comment.Nov 28 2018, 3:50 PM

Change 476295 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/Graph@master] ve.ui.MWGraphDialog: don't redefine actions

https://gerrit.wikimedia.org/r/476295

gerritbot added a comment.Nov 28 2018, 5:03 PM

Change 476295 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] ve.ui.MWGraphDialog: don't redefine actions

https://gerrit.wikimedia.org/r/476295

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Nov 28 2018, 5:42 PM
matmarex moved this task from Code review to Design and Product Analytics review on the VisualEditor (Current work) board.Nov 28 2018, 5:48 PM
matmarex added subscribers: • iamjessklein, matmarex.

(@iamjessklein said she wanted to take a look at this.)

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 28 2018, 6:00 PM
• iamjessklein added a comment.Nov 29 2018, 1:51 PM

👍this looks good to me. Thanks for figuring out the discrepancies @matmarex @Ryasmeen @Tchanders

• iamjessklein moved this task from Design and Product Analytics review to QA on the VisualEditor (Current work) board.Nov 29 2018, 1:58 PM
Ryasmeen added a project: Verified.Nov 29 2018, 9:41 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• marcella closed this task as Resolved.Dec 14 2018, 4:18 PM
• marcella claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 14 2018, 4:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL