Maniphest T205808

Ensure Revision::getRevisionText continues to function with MCR read-new mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Sep 30 2018, 9:32 PM

Description

Since T198341: Remove all references to the rev_text_id and ar_text_id fields and T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). have been pushed back and we support direct usage of rev_text_id and the text table even in MCR read-new mode, we have to ensure that Revision::getRevisionText keeps functioning in that mode.

To ensure this, we should make Revision::getRevisionText fall back to loading content via the RevisionStore if the fields from the text table are not present.

Details

	Subject	Repo	Branch	Lines +/-
	Allow getRevisionText to function without the text table.	mediawiki/core	master	+129 -34

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	daniel	T161671 Compacting the revision table
Duplicate	None	T184615 Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table
Stalled	None	T174043 Deploy Multi-Content Revisions
Resolved	daniel	T174044 Deploy MCR storage layer
Resolved	daniel	T205808 Ensure Revision::getRevisionText continues to function with MCR read-new mode

Event Timeline

daniel created this task.Sep 30 2018, 9:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2018, 9:32 PM

daniel mentioned this in T203925: Save times for changes to translation variable text in centralnotice paralysingly slow.Sep 30 2018, 9:34 PM

Change 463693 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Allow getRevisionText to function without the text table.

https://gerrit.wikimedia.org/r/463693

gerritbot added a project: Patch-For-Review.Sep 30 2018, 9:37 PM

daniel added a parent task: T174044: Deploy MCR storage layer.Oct 1 2018, 2:23 PM

CCicalese_WMF added projects: Platform Engineering (MCR: Deployment), Platform Team Legacy (Designing).Oct 2 2018, 1:32 PM

CCicalese_WMF moved this task from Inbox to Doing on the Platform Team Legacy (Designing) board.Oct 2 2018, 6:16 PM

daniel moved this task from Backlog to In Progress on the Multi-Content-Revisions (Deployment) board.Oct 4 2018, 9:47 AM

CCicalese_WMF moved this task from MCR: Deployment to MCR on the Platform Engineering board.Oct 4 2018, 3:12 PM

CCicalese_WMF edited projects, added Platform Engineering (MCR); removed Platform Engineering (MCR: Deployment).

CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Designing).Oct 14 2018, 3:59 PM

CCicalese_WMF moved this task from Doing to Waiting for Review on the Platform Team Workboards board.Oct 15 2018, 2:41 PM

CCicalese_WMF edited projects, added Platform Team Workboards (Waiting for Review); removed Platform Team Workboards (Doing).

Change 463693 merged by jenkins-bot:
[mediawiki/core@master] Allow getRevisionText to function without the text table.