Page MenuHomePhabricator

Ensure Revision::getRevisionText continues to function with MCR read-new mode
Closed, ResolvedPublic

Description

Since T198341: Remove all references to the rev_text_id and ar_text_id fields and T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). have been pushed back and we support direct usage of rev_text_id and the text table even in MCR read-new mode, we have to ensure that Revision::getRevisionText keeps functioning in that mode.

To ensure this, we should make Revision::getRevisionText fall back to loading content via the RevisionStore if the fields from the text table are not present.

Event Timeline

daniel created this task.Sep 30 2018, 9:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2018, 9:32 PM

Change 463693 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Allow getRevisionText to function without the text table.

https://gerrit.wikimedia.org/r/463693

Change 463693 merged by jenkins-bot:
[mediawiki/core@master] Allow getRevisionText to function without the text table.

https://gerrit.wikimedia.org/r/463693

daniel closed this task as Resolved.Oct 18 2018, 2:01 PM