Page MenuHomePhabricator

Set wgProofreadPagePageJoiner on zh.wikisource
Open, Needs TriagePublic

Description

As per discussion on T104566, please set:

wgProofreadPagePageJoiner = "__PAGEJOIN__"

on zh.wikisource. This is meant to revert the parsing behaviour change introduced by T104566, and return to the previous situation.

Event Timeline

Candalua created this task.Oct 1 2018, 8:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2018, 8:30 AM
Ankry added a subscriber: Ankry.Jan 2 2019, 5:03 PM

[...] I have already opened a request to disable this functionality on zh.source: T205826. I don't understand why it has not been done yet.

Maybe nobody knows how to create a patch?

I think the cleanest way to implement the config change required here is just to add the following section to InitialiseSettings.php:

'wgProofreadPagePageJoiner' => [
	'default' => '-',
	'zhwikisource' => "__PAGEJOIN__", // T205826
],

AFAICS, "__PAGEJOIN__" and "__PAGESEPARATOR__" are "magic" strings expected never to appear explicitely in the wikicode of any page in the Page namespace.

Until the T104566 is disabled in this (or another) way in zh.ws, we have few broken pages there.

And actually the T104566 seems to be useless in zh.ws and ja.ws at the moment: no need to remove the page separator when joining words as wgProofreadPagePageSeparator is set to the empty string there.

Restricted Application added a project: User-Zoranzoki21. · View Herald TranscriptJan 4 2019, 12:48 PM

Change 482502 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[operations/mediawiki-config@master] IS.php: Add wgProofreadPagePageJoiner, set it per default on '-' and at zhwikisource on PAGEJOIN

https://gerrit.wikimedia.org/r/482502

Zoranzoki21 moved this task from Inbox to To deploy on the User-Zoranzoki21 board.Jan 6 2019, 3:50 PM

Change 482502 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[operations/mediawiki-config@master] IS.php: Add wgProofreadPagePageJoiner, set it per default on '-' and at zhwikisource on PAGEJOIN

https://gerrit.wikimedia.org/r/482502