Page MenuHomePhabricator
Create Task
Maniphest T205834

Parts of text where language variant conversion is disabled are missing in VE
Closed, ResolvedPublic
Actions

Description

I was doing some cleanup of the translation made with CX1 on srwiki, removed some junk HTML added by it, and disabled variant conversion for some parts of the text.
When I switched to VE from source editing, it revealed that VE seems to completely skip the parts which have variant conversion disabled.

I am really sorry that gif which captures the problem has text in Serbian. To try helping, while recording the gif, I mark the parts in question.
If there is anything else I might help with to understand the problem, please ask.

ve-no-invariant.gif (915×1 px, 1 MB)

Details

SubjectRepoBranchLines +/-
ext.visualEditor.mwlanguage: Actually load all of the codemediawiki/extensions/VisualEditorwmf/1.32.0-wmf.23+6 -0
ext.visualEditor.mwlanguage: Actually load all of the codemediawiki/extensions/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

• Petar.petkovic created this task.Oct 1 2018, 9:14 AM
Esanders added a subscriber: cscott.Oct 1 2018, 2:02 PM

CC @cscott

matmarex subscribed.Oct 1 2018, 6:06 PM

Looks like we're not loading the code… ve.dm.MWLanguageVariantInlineNode is undefined. Must have been dropped during some cleanup.

matmarex claimed this task.Oct 1 2018, 6:19 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
gerritbot subscribed.Oct 1 2018, 6:37 PM

Change 463821 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ext.visualEditor.mwlanguage: Actually load all of the code

https://gerrit.wikimedia.org/r/463821

gerritbot added a project: Patch-For-Review.Oct 1 2018, 6:37 PM
matmarex added a comment.Oct 1 2018, 6:39 PM

It is a bit interesting though that they are invisible, though. I would expect this issue to just make the variant annotations non-editable. Apparently Parsoid represents these nodes as empty <span> tags: https://sr.wikipedia.org/api/rest_v1/page/html/Papirus_1

<span typeof="mw:LanguageVariant" data-mw-variant="{&quot;disabled&quot;:{&quot;t&quot;:&quot;I&quot;}}" id="mwHQ"></span>
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Oct 1 2018, 7:30 PM
gerritbot added a comment.Oct 1 2018, 7:43 PM

Change 463821 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ext.visualEditor.mwlanguage: Actually load all of the code

https://gerrit.wikimedia.org/r/463821

gerritbot added a comment.Oct 1 2018, 7:56 PM

Change 463842 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.23] ext.visualEditor.mwlanguage: Actually load all of the code

https://gerrit.wikimedia.org/r/463842

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 1 2018, 8:00 PM
Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Oct 1 2018, 8:03 PM
gerritbot added a comment.Oct 3 2018, 11:30 PM

Change 463842 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.23] ext.visualEditor.mwlanguage: Actually load all of the code

https://gerrit.wikimedia.org/r/463842

Stashbot mentioned this in T201081: Handle <audio> tags from Parsoid.Oct 3 2018, 11:44 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-10-03T23:44:57Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.23/extensions/VisualEditor/: Require Parsoid HTML 2.0.0, and handle its <audio> tags (T201081); ext.visualEditor.mwlanguage: Actually load all of the code (T205834) (duration: 00m 57s)

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review.Oct 3 2018, 11:59 PM
cscott added a comment.Oct 4 2018, 3:54 PM
In T205834#4631166, @matmarex wrote:

It is a bit interesting though that they are invisible, though. I would expect this issue to just make the variant annotations non-editable. Apparently Parsoid represents these nodes as empty <span> tags: https://sr.wikipedia.org/api/rest_v1/page/html/Papirus_1

<span typeof="mw:LanguageVariant" data-mw-variant="{&quot;disabled&quot;:{&quot;t&quot;:&quot;I&quot;}}" id="mwHQ"></span>

The idea is that post-processing fills in the <span> with the appropriate text for your language. Parsoid has an implementation it uses for read-views; VE has it's own implementation used for editing -- because VE wants to surface all the possible variants and make them editable, whereas for read views we want to select and present only one.

JTannerWMF added a project: Editing QA.Nov 6 2018, 5:31 PM
Ryasmeen moved this task from QA to Engineering QA on the VisualEditor (Current work) board.Nov 7 2018, 3:38 AM
matmarex moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.Nov 8 2018, 7:44 PM
matmarex moved this task from Product owner review to Engineering QA on the VisualEditor (Current work) board.
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Nov 14 2018, 4:30 PM
Esanders added a comment.Mar 9 2019, 4:18 PM

@Petar.petkovic or @cscott , could you verify this is fixed?

• Petar.petkovic closed this task as Resolved.Mar 9 2019, 10:26 PM
• Petar.petkovic removed subscribers: Stashbot, gerritbot.
In T205834#5012927, @Esanders wrote:

@Petar.petkovic or @cscott , could you verify this is fixed?

Sure. I checked and the problem is fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL