Page MenuHomePhabricator

Trailing empty line gets lost when editing
Closed, ResolvedPublic5 Story Points

Description

When an empty line is trailing the end of a block on the conflict solving view and I start editing the block and immediately save again the line gets lost.

Example starting point:

Paragraph0

Paragraph1


Paragraph2



Paragraph3

Edit:

Paragraph0

Paragraph1

Paragraph2


Paragraph3

Conflict view:

When I now edit the left side and immediately save, the result will have a the line underneath Paragraph2 removed. I would expect it to stay as it is.

Details

Related Gerrit Patches:
mediawiki/extensions/TwoColConflict : masterRight trim diff text from visible empty lines

Event Timeline

Lea_WMDE set the point value for this task to 3.Oct 2 2018, 12:30 PM

The idea is that the text editor simply always adds another line, which it then takes back at the end as well.

We should have another look into the issue, could be that the line is tracked separately and will be there when saving. Then it's just confusing and the line should be just omitted.

Seems to be a visual bug, the line should be omitted in the visual.

WMDE-Fisch changed the point value for this task from 3 to 5.

Change 467416 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Right trim diff text from visible empty lines

https://gerrit.wikimedia.org/r/467416

WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-10-09 board.

Change 467416 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Right trim diff text from visible empty lines

https://gerrit.wikimedia.org/r/467416

Lea_WMDE closed this task as Resolved.Oct 22 2018, 9:51 AM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-10-09 board.