Page MenuHomePhabricator
Create Task
Maniphest T205874

Block slugs have extra white left padding in Firefox
Closed, ResolvedPublic
Actions

Description

Looks like this regressed in May 2017 when we upgraded to OOUI 0.22:

Firefox:

image.png (51×468 px, 3 KB)

Chrome:

image.png (46×423 px, 4 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (1191c3687)mediawiki/extensions/VisualEditormaster+1 -2
Fix margin override on block slugVisualEditor/VisualEditormaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Oct 1 2018, 2:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2018, 2:40 PM
Esanders added a comment.Oct 1 2018, 2:46 PM

Also the padding around the icon on Chrome is uneven - there should be more space on the left of the '+'.

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Oct 1 2018, 2:47 PM
gerritbot subscribed.Oct 1 2018, 2:47 PM

Change 463774 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix margin override on block slug

https://gerrit.wikimedia.org/r/463774

gerritbot added a project: Patch-For-Review.Oct 1 2018, 2:47 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Oct 1 2018, 2:48 PM
Jdforrester-WMF assigned this task to Esanders.Oct 1 2018, 2:54 PM
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
gerritbot added a comment.Oct 1 2018, 2:56 PM

Change 463774 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix margin override on block slug

https://gerrit.wikimedia.org/r/463774

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Oct 1 2018, 7:20 PM
gerritbot added a comment.Oct 2 2018, 7:19 PM

Change 464018 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1191c3687)

https://gerrit.wikimedia.org/r/464018

gerritbot added a comment.Oct 2 2018, 7:44 PM

Change 464018 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1191c3687)

https://gerrit.wikimedia.org/r/464018

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 2 2018, 8:00 PM
JTannerWMF added a project: Editing QA.Nov 6 2018, 5:31 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Nov 8 2018, 9:06 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• marcella closed this task as Resolved.Nov 19 2018, 7:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits