Page MenuHomePhabricator
Create Task
Maniphest T205880

Deploy new English thank you email content and subject line
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The new thank you email got approved. Content is here: https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_2018-10-01

There's some fiddly stuff with [isRecurring] tags, we'll have to be careful when pushing out other translations to make sure they are done correctly. I also added the "RecurringRestarted" and "UnrecordedCharge" paragraphs just in case we need them again.

The preferred subject line is "Your $5 gift = free knowledge for billions" with $5 replaced by the donor's amount. If that's not possible (I think it's not in the subject line?) then it may just have to be "Your gift = free knowledge for billions".

Details

SubjectRepoBranchLines +/-
Update TY test to deal with subject tokenwikimedia/fundraising/crmmaster+6 -1
Update English TY letter and subjectwikimedia/fundraising/crmmaster+46 -31
Customize query in gerrit

Event Timeline

Pcoombe created this task.Oct 1 2018, 3:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2018, 3:39 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Oct 1 2018, 4:55 PM
• DStrine added a project: Fundraising Sprint Sasquatches can't find us either.Oct 1 2018, 5:03 PM
Ejegg subscribed.Oct 1 2018, 5:16 PM

Looks like we CAN do tokens in subject lines now :) I'll do some local testing to make sure those come out right.

• CCogdill_WMF added a comment.Oct 1 2018, 5:18 PM

Ooh, fun!

I want to note this kind of personalization gets extra complicated in our
appeal emails when it gets to translating, because currency symbols
sometimes appear on the right / left /with a space / without a space. I'm
not sure how the translations get set up, but we would need to be mindful
of that.

Ejegg added a comment.Oct 1 2018, 5:22 PM

Yep! In the TY letters we send the amount through a special localization library that has a lot of symbols and rules built in.

gerritbot subscribed.Oct 1 2018, 8:56 PM

Change 463846 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Update English TY letter and subject

https://gerrit.wikimedia.org/r/463846

gerritbot added a project: Patch-For-Review.Oct 1 2018, 8:56 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Sasquatches can't find us either board.Oct 1 2018, 9:19 PM
gerritbot added a comment.Oct 2 2018, 1:13 AM

Change 463846 merged by Ejegg:
[wikimedia/fundraising/crm@master] Update English TY letter and subject

https://gerrit.wikimedia.org/r/463846

Ejegg moved this task from Review to Done on the Fundraising Sprint Sasquatches can't find us either board.Oct 2 2018, 1:18 AM
Ejegg added a subscriber: • MNoorWMF.

OK @MNoorWMF, @CCogdill_WMF, @Pcoombe the new letter is deployed. All the amount / currency variations I tried look good in the subject line and the body.

Pcoombe added a comment.Oct 2 2018, 10:41 AM

I tested a few different amounts and one-time/recurring donations, and all looks good to me. Thanks!

Pcoombe closed this task as Resolved.Oct 2 2018, 11:03 AM
Pcoombe claimed this task.
gerritbot added a comment.Oct 2 2018, 4:07 PM

Change 463974 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Update TY test to deal with subject token

https://gerrit.wikimedia.org/r/463974

gerritbot added a comment.Oct 2 2018, 4:28 PM

Change 463974 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Update TY test to deal with subject token

https://gerrit.wikimedia.org/r/463974

Ejegg set the point value for this task to 2.Jul 5 2019, 1:28 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 5 2019, 2:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL