Page MenuHomePhabricator
Create Task
Maniphest T205884

Spicerack: split wmf-auto-reimage-lib into Spicerack modules
Closed, ResolvedPublic
Actions

Description

As part of the parent goal, the current wmf-auto-reimage-lib must be split and converted into multiple Spicerack modules (IPMI, Icinga, etc..)

Details

SubjectRepoBranchLines +/-
administrative: add owner getter to Reason classoperations/software/spicerackmaster+17 -4
puppet: add delete() method to remove a hostoperations/software/spicerackmaster+19 -0
spicerack: fix versionoperations/software/spicerackmaster+2 -2
API: convert to new Spicerack APIoperations/cookbooksmaster+169 -71
debmonitor: use the existing configuration fileoperations/software/spicerackmaster+22 -17
config: add load_ini_config() functionoperations/software/spicerackmaster+29 -1
phabricator: remove unneded pylint ignoreoperations/software/spicerackmaster+1 -1
ipmi: add support for DRY RUN modeoperations/software/spicerackmaster+22 -9
puppet: fix regenerate_certificate()operations/software/spicerackmaster+42 -6
puppet: add default batch_size when running puppetoperations/software/spicerackmaster+7 -4
debmonitor: add debmonitor moduleoperations/software/spicerackmaster+142 -2
phabricator: add phabricator moduleoperations/software/spicerackmaster+208 -1
CHANGELOG: add changelogs for release v0.0.10operations/software/spicerackmaster+47 -0
interactive: check TTY in ask_confirmation()operations/software/spicerackmaster+25 -7
remote: add more functionalitiesoperations/software/spicerackmaster+189 -4
icinga: add execution of Icinga commandsoperations/software/spicerackmaster+130 -3
spicerack: configure APT component/spicerackoperations/puppetproduction+14 -3
puppet: add additional methods to PuppetHostsoperations/software/spicerackmaster+294 -13
icinga: fix typo in test docstringoperations/software/spicerackmaster+1 -1
Add ipmi moduleoperations/software/spicerackmaster+339 -0
puppet: add PuppetMaster classoperations/software/spicerackmaster+462 -7
apt: add component/spicerack supportoperations/puppetproduction+20 -1
administrative: fix Reason's signatureoperations/software/spicerackmaster+3 -3
Add Puppet moduleoperations/software/spicerackmaster+118 -1
Add Icinga moduleoperations/software/spicerackmaster+133 -1
Add administrative moduleoperations/software/spicerackmaster+149 -27
remote: refactor Remote.query() APIoperations/software/spicerackmaster+187 -158
interactive: add ensure_shell_is_durable()operations/software/spicerackmaster+44 -0
dns: add dns moduleoperations/software/spicerackmaster+351 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Volans triaged this task as Medium priority.Oct 1 2018, 3:57 PM
Volans created this task.
Volans claimed this task.Oct 22 2018, 9:22 AM
Volans moved this task from Backlog to In Progress on the SRE-tools board.
gerritbot subscribed.Nov 2 2018, 10:50 AM

Change 471238 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] dns: add dns module

https://gerrit.wikimedia.org/r/471238

gerritbot added a project: Patch-For-Review.Nov 2 2018, 10:50 AM
gerritbot added a comment.Nov 6 2018, 4:16 PM

Change 471238 merged by jenkins-bot:
[operations/software/spicerack@master] dns: add dns module

https://gerrit.wikimedia.org/r/471238

gerritbot added a comment.Nov 13 2018, 2:19 PM

Change 473212 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] interactive: add ensure_shell_session()

https://gerrit.wikimedia.org/r/473212

gerritbot added a comment.Nov 13 2018, 2:19 PM

Change 473213 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] remote: refactor Remote.query() API

https://gerrit.wikimedia.org/r/473213

gerritbot added a comment.Nov 13 2018, 9:05 PM

Change 473212 merged by jenkins-bot:
[operations/software/spicerack@master] interactive: add ensure_shell_is_durable()

https://gerrit.wikimedia.org/r/473212

gerritbot added a comment.Nov 14 2018, 2:18 PM

Change 473506 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] Add Icinga module

https://gerrit.wikimedia.org/r/473506

gerritbot added a comment.Nov 15 2018, 10:27 AM

Change 473213 merged by jenkins-bot:
[operations/software/spicerack@master] remote: refactor Remote.query() API

https://gerrit.wikimedia.org/r/473213

gerritbot added a comment.Nov 15 2018, 1:29 PM

Change 473735 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] Add Puppet module

https://gerrit.wikimedia.org/r/473735

gerritbot added a comment.Nov 15 2018, 5:34 PM

Change 473796 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] Add administrative module

https://gerrit.wikimedia.org/r/473796

gerritbot added a comment.Nov 20 2018, 3:24 PM

Change 473796 merged by jenkins-bot:
[operations/software/spicerack@master] Add administrative module

https://gerrit.wikimedia.org/r/473796

gerritbot added a comment.Nov 20 2018, 3:56 PM

Change 473506 merged by jenkins-bot:
[operations/software/spicerack@master] Add Icinga module

https://gerrit.wikimedia.org/r/473506

gerritbot added a comment.Nov 20 2018, 3:59 PM

Change 473735 merged by jenkins-bot:
[operations/software/spicerack@master] Add Puppet module

https://gerrit.wikimedia.org/r/473735

gerritbot added a comment.Dec 3 2018, 12:51 PM

Change 477256 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] administrative: fix Reason's signature

https://gerrit.wikimedia.org/r/477256

gerritbot added a comment.Dec 3 2018, 1:52 PM

Change 477256 merged by jenkins-bot:
[operations/software/spicerack@master] administrative: fix Reason's signature

https://gerrit.wikimedia.org/r/477256

gerritbot added a comment.Dec 5 2018, 12:13 AM

Change 477707 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] puppet: add PuppetMaster class

https://gerrit.wikimedia.org/r/477707

gerritbot added a comment.Dec 6 2018, 5:09 PM

Change 478030 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] Add ipmi module

https://gerrit.wikimedia.org/r/478030

gerritbot added a comment.Dec 11 2018, 1:19 PM

Change 478931 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] icinga: fix typo in test docstring

https://gerrit.wikimedia.org/r/478931

gerritbot added a comment.Dec 13 2018, 1:34 PM

Change 479431 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] puppet: add additional methods to PuppetHosts

https://gerrit.wikimedia.org/r/479431

gerritbot added a comment.Dec 13 2018, 3:55 PM

Change 479463 had a related patch set uploaded (by Volans; owner: Volans):
[operations/cookbooks@master] API: convert to new Spicerack API

https://gerrit.wikimedia.org/r/479463

gerritbot added a comment.Dec 13 2018, 6:49 PM

Change 479506 had a related patch set uploaded (by Volans; owner: Volans):
[operations/puppet@production] package_builder: add component/spicerack support

https://gerrit.wikimedia.org/r/479506

gerritbot added a comment.Dec 13 2018, 7:21 PM

Change 479506 merged by Volans:
[operations/puppet@production] apt: add component/spicerack support

https://gerrit.wikimedia.org/r/479506

Stashbot subscribed.Dec 13 2018, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-13T19:39:53Z] <volans> imported python-elasticsearch_5.4.0-1~deb9u1 into apt.w.o stretch-wikimedia component/spicerack - T205884

Stashbot added a comment.Dec 13 2018, 8:21 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-13T20:21:32Z] <volans> imported elasticsearch-curator_5.2.0-1~deb9u1 into apt.w.o stretch-wikimedia component/spicerack - T205884

gerritbot added a comment.Dec 13 2018, 9:47 PM

Change 479555 had a related patch set uploaded (by Volans; owner: Volans):
[operations/puppet@production] spicerack: configure APT component/spicerack

https://gerrit.wikimedia.org/r/479555

gerritbot added a comment.Dec 15 2018, 11:40 AM

Change 477707 merged by jenkins-bot:
[operations/software/spicerack@master] puppet: add PuppetMaster class

https://gerrit.wikimedia.org/r/477707

gerritbot added a comment.Dec 15 2018, 11:43 AM

Change 478030 merged by jenkins-bot:
[operations/software/spicerack@master] Add ipmi module

https://gerrit.wikimedia.org/r/478030

gerritbot added a comment.Dec 15 2018, 11:46 AM

Change 478931 merged by jenkins-bot:
[operations/software/spicerack@master] icinga: fix typo in test docstring

https://gerrit.wikimedia.org/r/478931

gerritbot added a comment.Dec 15 2018, 11:59 AM

Change 479431 merged by jenkins-bot:
[operations/software/spicerack@master] puppet: add additional methods to PuppetHosts

https://gerrit.wikimedia.org/r/479431

gerritbot added a comment.Dec 15 2018, 12:00 PM

Change 479555 merged by Volans:
[operations/puppet@production] spicerack: configure APT component/spicerack

https://gerrit.wikimedia.org/r/479555

gerritbot added a comment.Dec 17 2018, 12:20 PM

Change 480063 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] icinga: add execution of Icinga commands

https://gerrit.wikimedia.org/r/480063

gerritbot added a comment.Dec 17 2018, 12:20 PM

Change 480064 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] remote: add more functionalities

https://gerrit.wikimedia.org/r/480064

gerritbot added a comment.Dec 17 2018, 6:07 PM

Change 480063 merged by jenkins-bot:
[operations/software/spicerack@master] icinga: add execution of Icinga commands

https://gerrit.wikimedia.org/r/480063

gerritbot added a comment.Dec 18 2018, 1:28 PM

Change 480485 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] interactive: check TTY in ask_confirmation()

https://gerrit.wikimedia.org/r/480485

gerritbot added a comment.Dec 19 2018, 10:58 AM

Change 480064 merged by jenkins-bot:
[operations/software/spicerack@master] remote: add more functionalities

https://gerrit.wikimedia.org/r/480064

gerritbot added a comment.Dec 19 2018, 2:38 PM

Change 480485 merged by jenkins-bot:
[operations/software/spicerack@master] interactive: check TTY in ask_confirmation()

https://gerrit.wikimedia.org/r/480485

gerritbot added a comment.Dec 19 2018, 3:11 PM

Change 480757 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] CHANGELOG: add changelogs for release v0.0.10

https://gerrit.wikimedia.org/r/480757

gerritbot added a comment.Dec 19 2018, 3:30 PM

Change 480757 merged by jenkins-bot:
[operations/software/spicerack@master] CHANGELOG: add changelogs for release v0.0.10

https://gerrit.wikimedia.org/r/480757

Volans added a comment.Dec 19 2018, 6:31 PM

~95% of the library has been migrated into Spicerack. I'm leaving this open as few bits are still missing to call it done.

gerritbot added a comment.Jan 3 2019, 1:42 PM

Change 482018 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] phabricator: add phabricator module

https://gerrit.wikimedia.org/r/482018

gerritbot added a comment.Jan 4 2019, 1:39 PM

Change 482299 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] debmonitor: add debmonitor module

https://gerrit.wikimedia.org/r/482299

ops-monitoring-bot subscribed.Jan 8 2019, 9:23 AM

test comment from spicerack

gerritbot added a comment.Jan 8 2019, 10:01 AM

Change 482018 merged by jenkins-bot:
[operations/software/spicerack@master] phabricator: add phabricator module

https://gerrit.wikimedia.org/r/482018

gerritbot added a comment.Jan 8 2019, 10:24 AM

Change 482299 merged by jenkins-bot:
[operations/software/spicerack@master] debmonitor: add debmonitor module

https://gerrit.wikimedia.org/r/482299

Stashbot added a comment.Jan 9 2019, 10:00 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-09T10:00:00Z] <volans> uploaded spicerack_0.0.11 to apt.wikimedia.org stretch-wikimedia T205884

Stashbot added a comment.Jan 9 2019, 10:01 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-09T10:01:09Z] <volans> upgraded spicerack to 0.0.11 on cumin2001 T205884

ops-monitoring-bot added a comment.Jan 10 2019, 2:46 PM

test comment from spicerack

gerritbot added a comment.Jan 10 2019, 4:11 PM

Change 483454 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] puppet: add default batch_size when running puppet

https://gerrit.wikimedia.org/r/483454

gerritbot added a comment.Jan 10 2019, 4:11 PM

Change 483455 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] puppet: fix regenerate_certificate()

https://gerrit.wikimedia.org/r/483455

gerritbot added a comment.Jan 10 2019, 4:11 PM

Change 483456 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] ipmi: add support for DRY RUN mode

https://gerrit.wikimedia.org/r/483456

gerritbot added a comment.Jan 10 2019, 4:11 PM

Change 483457 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] phabricator: remove unneded pylint ignore

https://gerrit.wikimedia.org/r/483457

gerritbot added a comment.Jan 10 2019, 4:11 PM

Change 483458 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] config: add load_ini_config() function

https://gerrit.wikimedia.org/r/483458

gerritbot added a comment.Jan 10 2019, 4:11 PM

Change 483459 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] debmonitor: use the existing configuration file

https://gerrit.wikimedia.org/r/483459

gerritbot added a comment.Jan 10 2019, 5:23 PM

Change 483454 merged by jenkins-bot:
[operations/software/spicerack@master] puppet: add default batch_size when running puppet

https://gerrit.wikimedia.org/r/483454

gerritbot added a comment.Jan 10 2019, 5:39 PM

Change 483455 merged by jenkins-bot:
[operations/software/spicerack@master] puppet: fix regenerate_certificate()

https://gerrit.wikimedia.org/r/483455

gerritbot added a comment.Jan 10 2019, 5:46 PM

Change 483456 merged by jenkins-bot:
[operations/software/spicerack@master] ipmi: add support for DRY RUN mode

https://gerrit.wikimedia.org/r/483456

gerritbot added a comment.Jan 10 2019, 5:54 PM

Change 483457 merged by jenkins-bot:
[operations/software/spicerack@master] phabricator: remove unneded pylint ignore

https://gerrit.wikimedia.org/r/483457

gerritbot added a comment.Jan 10 2019, 6:01 PM

Change 483458 merged by jenkins-bot:
[operations/software/spicerack@master] config: add load_ini_config() function

https://gerrit.wikimedia.org/r/483458

gerritbot added a comment.Jan 10 2019, 6:11 PM

Change 483459 merged by jenkins-bot:
[operations/software/spicerack@master] debmonitor: use the existing configuration file

https://gerrit.wikimedia.org/r/483459

Stashbot added a comment.Jan 10 2019, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-10T19:39:57Z] <volans> uploaded spicerack_0.0.12-1_amd64.deb to apt.wikimedia.org stretch-wikimedia T205884

Stashbot added a comment.Jan 10 2019, 7:41 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-10T19:41:11Z] <volans> installed spicerack 0.0.12-1 on cumin2001 T205884

Stashbot added a comment.Jan 14 2019, 10:11 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T10:11:48Z] <volans> uploaded spicerack_0.0.13-1_amd64.deb to apt.wikimedia.org stretch-wikimedia T205884

Stashbot added a comment.Jan 14 2019, 10:13 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T10:13:23Z] <volans> installed spicerack 0.0.13 on cumin2001 for final testing - T205884

Stashbot added a comment.Jan 14 2019, 11:20 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T11:20:47Z] <volans> installed spicerack 0.0.13 on cumin1001 - T205884

gerritbot added a comment.Jan 14 2019, 11:26 AM

Change 479463 merged by jenkins-bot:
[operations/cookbooks@master] API: convert to new Spicerack API

https://gerrit.wikimedia.org/r/479463

Stashbot added a comment.Jan 14 2019, 2:36 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T14:36:06Z] <volans> uploaded python{,3}-phabricator 0.7.0-2~wmf1 to apt.w.o T205884 (upstream removes egg files)

Stashbot added a comment.Jan 14 2019, 2:39 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T14:39:21Z] <volans> updated python3-phabricator on cumin[12]001 T205884

gerritbot added a comment.Jan 14 2019, 3:01 PM

Change 484239 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] spicerack: fix version

https://gerrit.wikimedia.org/r/484239

Stashbot added a comment.Jan 14 2019, 3:08 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-14T15:08:49Z] <volans> testing switchdc cookbooks in DRY-RUN mode w/ latest spicerack T205884 (no real changes expected)

gerritbot added a comment.Jan 22 2019, 6:29 PM

Change 484239 merged by jenkins-bot:
[operations/software/spicerack@master] spicerack: fix version

https://gerrit.wikimedia.org/r/484239

gerritbot added a comment.Feb 5 2019, 2:30 AM

Change 487981 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] puppet: add delete() method to remove a host

https://gerrit.wikimedia.org/r/487981

gerritbot added a comment.Feb 5 2019, 11:43 PM

Change 488204 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/spicerack@master] administrative: add owner getter to Reason class

https://gerrit.wikimedia.org/r/488204

gerritbot added a comment.Feb 7 2019, 2:06 AM

Change 487981 merged by jenkins-bot:
[operations/software/spicerack@master] puppet: add delete() method to remove a host

https://gerrit.wikimedia.org/r/487981

gerritbot added a comment.Feb 7 2019, 2:28 AM

Change 488204 merged by jenkins-bot:
[operations/software/spicerack@master] administrative: add owner getter to Reason class

https://gerrit.wikimedia.org/r/488204

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:51 PM
Volans added a comment.Nov 4 2019, 2:01 PM

Most of the modules and functionalities have been added. I've not had a chance to work on this in a while, I hope to get back to it soon. Leaving it open in the meanwhile as some minor bits were still missing to include all the current functionalities of the reimage library.

Volans removed Volans as the assignee of this task.Nov 23 2020, 8:43 PM
Volans claimed this task.
Aklapper added a project: Infrastructure-Foundations.Jun 21 2021, 8:59 PM
joanna_borun moved this task from Backlog to In Progress on the Infrastructure-Foundations board.Aug 9 2021, 1:25 PM
joanna_borun changed the task status from Open to In Progress.Sep 21 2021, 4:05 PM
Volans closed this task as Resolved.Oct 11 2021, 10:28 AM

With the completion of the conversion of the reimage script to the sre.hosts.reimage cookbook, all the needed bits that were missing in spicerack has been added. Resolving.

Volans mentioned this in rCCKB5991404516f1: API: convert to new Spicerack API.Dec 14 2022, 3:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits