Page MenuHomePhabricator
Create Task
Maniphest T205891

Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block
Closed, ResolvedPublic
Actions

Description

Per Ramsey.

Details

SubjectRepoBranchLines +/-
Display captions block immediately after the file links, before the wikitext contentmediawiki/extensions/WikibaseMediaInfomaster+499 -193
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
Resolved• Ramsey-WMFT205732 Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions)
ResolvedCparleT205891 Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block
· · ·

Event Timeline

Jdforrester-WMF created this task.Oct 1 2018, 4:51 PM
Jdforrester-WMF added a subtask: T200915: Allow SlotRoleHandlers to control page layout.
Jdforrester-WMF moved this task from To Do to Blocked on the Structured Data Engineering board.Oct 11 2018, 7:14 PM
• Ramsey-WMF triaged this task as High priority.Oct 17 2018, 5:11 PM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
Agabi10 added a subscriber: Agabi10.Nov 9 2018, 12:01 AM
Jdforrester-WMF changed the task status from Open to Stalled.Nov 9 2018, 5:04 PM
Jdforrester-WMF mentioned this in T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions).Nov 16 2018, 7:44 PM
daniel added a subscriber: daniel.Nov 20 2018, 9:41 AM

We need to distinguish between two solutions for this: client side DOM manipulation, and server side layout during page rendering. The former can be done quickly but should probably be considered a temporary solution. The latter needs quite a bit of infrastructure on the server side, if we want to provide a mechanism for this that would cover more use cases. The necessary control over the layout cannot be covered by T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles. but would probably need something like T209924: Specify PageTypeHandler.

daniel added a comment.EditedNov 20 2018, 9:45 AM

Please clarify: per the task description, one could assume that the desired order of things on a file description page would become:

[File]
[MediaInfo]
[Wikitext]
[File history]
[Usage]
[Exif]

Buf if I understand correctly, the desired layout is actually

[File]
[MediaInfo captions]
[Wikitext]
[MediaInfo statements]
[File history]
[Usage]
[Exif]

This is a very important distinction, since the former is possible with SlotRoleHandler, but the latter is not!

daniel added a subtask: T209924: Specify PageTypeHandler.Nov 20 2018, 9:49 AM
daniel added a subtask: T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles..
daniel added a subtask: T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots.Nov 20 2018, 9:53 AM
daniel added a subtask: T195212: ServiceContainer: Allow extensions to manipulate services upon creation.Nov 20 2018, 9:55 AM
daniel added a subtask: T209878: Allow control of page layout of multiple slots during rendering.Nov 20 2018, 9:59 AM
daniel closed subtask T195212: ServiceContainer: Allow extensions to manipulate services upon creation as Resolved.
Jdforrester-WMF mentioned this in T209878: Allow control of page layout of multiple slots during rendering.Nov 20 2018, 4:25 PM
Jdforrester-WMF added a comment.Nov 20 2018, 4:30 PM
In T205891#4761276, @daniel wrote:

Please clarify: per the task description, one could assume that the desired order of things on a file description page would become:

[File]
[MediaInfo]
[Wikitext]
[File history]
[Usage]
[Exif]

Buf if I understand correctly, the desired layout is actually

[File]
[MediaInfo captions]
[Wikitext]
[MediaInfo statements]
[File history]
[Usage]
[Exif]

This is a very important distinction, since the former is possible with SlotRoleHandler, but the latter is not!

Correct. However, statements are a less immediate need than captions.

gerritbot added a subscriber: gerritbot.Nov 22 2018, 12:57 PM

Change 475316 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Work in progress

https://gerrit.wikimedia.org/r/475316

gerritbot added a project: Patch-For-Review.Nov 22 2018, 12:57 PM
Cparle mentioned this in rEWBId9c13181b6fe: Work in progress.Nov 22 2018, 12:58 PM
Cparle mentioned this in rEWBIef221319f426: Work in progress.Nov 22 2018, 5:24 PM
Cparle mentioned this in rEWBI1bf5f5d15352: Work in progress.Nov 23 2018, 5:56 PM
Cparle mentioned this in rEWBI3e4f6fc9538d: Work in progress.Nov 26 2018, 1:15 PM
Cparle mentioned this in rEWBIcb8657dfa5e9: Work in progress.Nov 26 2018, 1:17 PM
Cparle mentioned this in rEWBI1b3eb13d1437: Work in progress.Nov 26 2018, 6:53 PM
Jdforrester-WMF mentioned this in rEWBIaee3294df9cc: Display captions block immediately after the file links, before the wikitext….Nov 26 2018, 9:32 PM
Jdforrester-WMF mentioned this in rEWBI30d7d51a3153: Display captions block immediately after the file links, before the wikitext….Nov 26 2018, 10:33 PM
Jdforrester-WMF mentioned this in rEWBI0833cd0d66f8: Display captions block immediately after the file links, before the wikitext….Nov 26 2018, 10:58 PM
Jdforrester-WMF mentioned this in rEWBIaff51ce74b73: Display captions block immediately after the file links, before the wikitext….Nov 26 2018, 11:49 PM
Jdforrester-WMF mentioned this in rEWBI028851eaeb5b: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 12:00 AM
Jdforrester-WMF mentioned this in rEWBIa841b7ad707e: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 12:40 AM
Jdforrester-WMF mentioned this in rEWBI8378a5ba5e32: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 1:39 AM
Jdforrester-WMF mentioned this in rEWBIf5535a5898c4: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 2:07 AM
Cparle mentioned this in rEWBIa4db526cbff7: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 10:54 AM
Cparle mentioned this in rEWBI2f1d814b1aaf: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 11:53 AM
Cparle mentioned this in rEWBIa190c08858b4: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 1:03 PM
Cparle mentioned this in rEWBI370aee7bb990: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 2:17 PM
Cparle mentioned this in rEWBI4bcf8bffeaff: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 3:34 PM
Cparle mentioned this in rEWBI14d84b505cb0: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 3:55 PM
Cparle mentioned this in rEWBI07370a808851: Display captions block immediately after the file links, before the wikitext….Nov 27 2018, 4:02 PM
Cparle mentioned this in rEWBI52772246dcb5: Display captions block immediately after the file links, before the wikitext….Nov 28 2018, 11:35 AM
Cparle moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.Nov 28 2018, 11:53 AM
Jdforrester-WMF changed the task status from Stalled to Open.Nov 28 2018, 4:45 PM
Jdforrester-WMF assigned this task to Cparle.
Jdforrester-WMF removed subtasks: T209878: Allow control of page layout of multiple slots during rendering, T195212: ServiceContainer: Allow extensions to manipulate services upon creation, T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots, T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles., T209924: Specify PageTypeHandler, T200915: Allow SlotRoleHandlers to control page layout.
Jdforrester-WMF moved this task from Blocked to Verify on Production on the Structured Data Engineering board.

We did a local hack in WBMI to make this happen. Eventually the former sub-tasks will be fixed, at which point we should migrate to the proper fix.

Jdforrester-WMF moved this task from Code Review to Needs QA on the Multimedia-Team-Working-Board board.Nov 28 2018, 4:46 PM
gerritbot added a comment.Nov 28 2018, 5:40 PM

Change 475316 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Display captions block immediately after the file links, before the wikitext content

https://gerrit.wikimedia.org/r/475316

Cparle mentioned this in T211134: Backfill unit tests for T205891.Dec 4 2018, 5:57 PM
Jdforrester-WMF added a comment.Dec 4 2018, 8:19 PM

Will be fully fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/477613

• Ramsey-WMF closed this task as Resolved.Dec 12 2018, 11:43 PM
• Ramsey-WMF added a subscriber: • Ramsey-WMF.

Tested on Beta. The temporary fix works.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL