Maniphest T205916

Current version of text extracts list compatibility with 1.29 but uses 1.30 code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Valeryan_M
	Oct 1 2018, 7:14 PM

Description

Extension.json list the requirements for "MediaWiki": ">= 1.29.0" but in ApiQueryExtracts.php on line 238 you are using MediaWikiServices::getInstance()->getParserCache() which did not become available until MW 1.30.

Details

	Subject	Repo	Branch	Lines +/-
	Raise mediawiki requirement to 1.30	mediawiki/extensions/TextExtracts	master	+1 -1

Customize query in gerrit

Event Timeline

Valeryan_M created this task.Oct 1 2018, 7:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2018, 7:14 PM

Please feel free to submit a patch to fix this! Will happily review.

Change 464138 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/TextExtracts@master] Raise mediawiki requirement to 1.30

https://gerrit.wikimedia.org/r/464138

gerritbot added a project: Patch-For-Review.Oct 3 2018, 12:24 PM

We should really have some CI linting on issues like this. Happens way too often.

Change 464138 merged by Jdlrobson:
[mediawiki/extensions/TextExtracts@master] Raise mediawiki requirement to 1.30

https://gerrit.wikimedia.org/r/464138

Thanks @TheDJ what would such linting look like? Shall we open a task?

Jdlrobson closed this task as Resolved.Oct 3 2018, 4:10 PM

Jdlrobson claimed this task.

Aklapper removed a project: Google-Code-in-2018.Oct 3 2018, 4:23 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 3 2018, 5:00 PM

Current version of text extracts list compatibility with 1.29 but uses 1.30 codeClosed, ResolvedPublicActions

Description

Details

Event Timeline

Current version of text extracts list compatibility with 1.29 but uses 1.30 code
Closed, ResolvedPublic
Actions