Page MenuHomePhabricator

TimeParsingTest::testSeconds2NptFormat fails on PHP 7.1
Closed, ResolvedPublic

Description

01:07:35 There was 1 error:
01:07:35 
01:07:35 1) TimeParsingTest::testSeconds2NptFormat
01:07:35 A non-numeric value encountered
01:07:35 
01:07:35 /workspace/src/extensions/TimedMediaHandler/includes/TimedMediaHandler.php:297
01:07:35 /workspace/src/extensions/TimedMediaHandler/tests/phpunit/TimeParsingTest.php:24
01:07:35 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php71-docker/1/consoleFull

Can be verified by commenting "check experimental" on a patch to trigger the PHP 7.1 job.

Event Timeline

Legoktm created this task.Oct 2 2018, 8:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 8:09 AM

Change 463998 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@master] tests: Use assertFalse not assertEquals(…, false) for PHP7.1 compat

https://gerrit.wikimedia.org/r/463998

Legoktm closed this task as Resolved.Oct 2 2018, 7:02 PM

Change 463998 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat

https://gerrit.wikimedia.org/r/463998

Change 615773 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/extensions/TimedMediaHandler@REL1_31] tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat

https://gerrit.wikimedia.org/r/615773

Change 615773 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@REL1_31] tests: Use assertFalse not assertEquals(…, false) and other tweaks for PHP7.1 compat

https://gerrit.wikimedia.org/r/615773