Page MenuHomePhabricator

OOUI's JS widgets and dialogs demos are broken by trying to still use CapsuleMultiselectWidget which no longer exists
Closed, ResolvedPublic

Description

Reported in Chrome DevTools console when visiting https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop:

widgets.js:2835 Uncaught TypeError: (intermediate value).addItemsFromData is not a function
    at Object.Demo.static.pages.widgets (widgets.js:2835)
    at Array.<anonymous> (demo.js:299)
    at fire (jquery.js:3268)
    at Object.fireWith [as resolveWith] (jquery.js:3398)
    at HTMLLinkElement.<anonymous> (jquery.js:3781)
    at fire (jquery.js:3268)
    at Object.fireWith [as resolveWith] (jquery.js:3398)
    at HTMLLinkElement.deferred.(/oojs-ui/master/demos/anonymous function) (https://doc.wikimedia.org/oojs-ui/master/demos/node_modules/jquery/dist/jquery.js:3736:36)
    at HTMLLinkElement.dispatch (jquery.js:5183)
    at HTMLLinkElement.elemData.handle (jquery.js:4991)

This error is serious enough that it prevents rendering the page content, resulting only in an empty page with the navigation bar at the top.

Also the PHP demo results in a HTTP 500 error: https://doc.wikimedia.org/oojs-ui/master/demos/demos.php.
So far only the Dialogs, Icons and Toolbars sections of the JavaScript Demo seem to work.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 2:12 PM
Mainframe98 renamed this task from Viewing the JS demo results in an empty page to Most OOUI demos are broken.Oct 2 2018, 2:15 PM
Mainframe98 updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.Oct 2 2018, 6:29 PM

Ehhhh, contint1001 is running Debian Jessie / PHP 5.6 and OOUI just started requiring PHP 7+. Probably we should switch it to using PHP 7.2 packages...

Ehhhh, contint1001 is running Debian Jessie / PHP 5.6 and OOUI just started requiring PHP 7+. Probably we should switch it to using PHP 7.2 packages...

Oops, yes (but the JS demos stack doesn't go through PHP…).

Change 464054 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [WIP] demos: Unbreak from reliance on removed CapsuleMSW

https://gerrit.wikimedia.org/r/464054

Paladox added a subscriber: Paladox.Oct 2 2018, 9:40 PM

Change 464054 merged by jenkins-bot:
[oojs/ui@master] demos: Unbreak from reliance on removed CapsuleMultiselectWidget

https://gerrit.wikimedia.org/r/464054

Volker_E moved this task from Backlog to OOUI-0.29.0 on the OOUI board.Oct 2 2018, 10:56 PM
Volker_E edited projects, added OOUI (OOUI-0.29.0); removed OOUI.
Volker_E closed this task as Resolved.Oct 3 2018, 1:54 AM
Volker_E assigned this task to Jdforrester-WMF.
Volker_E triaged this task as High priority.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.

Change 464370 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.29.0

https://gerrit.wikimedia.org/r/464370

Jdforrester-WMF renamed this task from Most OOUI demos are broken to Most OOUI JS widgets and dialogs demos are broken by trying to still use CapsuleMultiselectWidget which no longer exists.Oct 3 2018, 7:50 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF renamed this task from Most OOUI JS widgets and dialogs demos are broken by trying to still use CapsuleMultiselectWidget which no longer exists to OOUI's JS widgets and dialogs demos are broken by trying to still use CapsuleMultiselectWidget which no longer exists.Oct 3 2018, 7:56 PM

Change 464607 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

Change 464370 abandoned by Jforrester:
Update OOUI to v0.29.0

Reason:
Replaced by Ie847465af6762.

https://gerrit.wikimedia.org/r/464370

Change 464607 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607