Page MenuHomePhabricator
Create Task
Maniphest T206000

Apply changes action is enabled on several dialogs before any changes are made
Closed, ResolvedPublic
Actions

Description

The "Apply changes" button should appear grey and be disabled when a dialog is first opened, until changes are made; however, on some dialogs, it is blue and already active.

Affected dialogs (see also table of screenshots in T202575#4551941):

Related Objects
Search...

Event Timeline

Tchanders created this task.Oct 2 2018, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 5:49 PM
Tchanders updated the task description. (Show Details)Oct 2 2018, 5:50 PM
Tchanders mentioned this in T190885: Re-evaluate mobile editing for images .Oct 2 2018, 6:06 PM
Tchanders moved this task from To Triage to Q4 on the VisualEditor board.Oct 3 2018, 2:45 PM
JTannerWMF moved this task from Q4 to Current work on the VisualEditor board.Oct 3 2018, 4:58 PM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.
Tchanders claimed this task.Oct 8 2018, 3:32 PM
Tchanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.
• iamjessklein awarded a token.Oct 8 2018, 3:35 PM
Deskana closed subtask T206481: The syntax highlight dialog's Apply changes action is enabled and disabled erratically as Resolved.Oct 11 2018, 3:04 PM
Deskana closed subtask T206473: Opening the maps dialog causes a change in the maps node attributes as Resolved.Oct 11 2018, 3:10 PM
matmarex added a subtask: T207719: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled.Oct 23 2018, 4:44 AM
matmarex closed subtask T207719: The meta dialog's ("Page options" dialog) "Apply changes" action is always enabled as Resolved.Nov 2 2018, 12:03 AM
• marcella removed Tchanders as the assignee of this task.Nov 7 2018, 1:43 PM
matmarex claimed this task.Nov 7 2018, 3:06 PM
matmarex updated the task description. (Show Details)Nov 15 2018, 2:58 PM
matmarex updated the task description. (Show Details)Nov 15 2018, 11:35 PM
matmarex moved this task from In progress to Code review on the VisualEditor (Current work) board.Nov 16 2018, 12:12 AM
matmarex added a subtask: T210796: The citation (with template) dialog's Apply changes action is always enabled.Nov 29 2018, 9:59 PM
matmarex updated the task description. (Show Details)
• marcella closed subtask T209661: The transclusion/template dialog's Apply changes action is always enabled as Resolved.Dec 14 2018, 4:17 PM
• marcella closed subtask T209660: The references list dialog's Apply changes action is always enabled as Resolved.Dec 14 2018, 4:21 PM
matmarex updated the task description. (Show Details)Jan 9 2019, 7:45 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.

All of the known issues (subtasks) are resolved. I guess we just want to double-check that all dialogs behave correctly now.

• marcella closed subtask T206534: The gallery dialog's Apply changes action is always enabled if there are images in the gallery as Resolved.Jan 15 2019, 2:25 PM
• marcella closed subtask T210796: The citation (with template) dialog's Apply changes action is always enabled as Resolved.
• marcella added a project: Editing QA.Jan 16 2019, 7:20 PM
Esanders moved this task from Inbox to Low Priority on the Editing QA board.Feb 7 2019, 7:07 PM
Ryasmeen added a project: Verified.Feb 8 2019, 10:47 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Ryasmeen removed a project: Editing QA.
ppelberg closed this task as Resolved.Mar 6 2019, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL