Page MenuHomePhabricator
Create Task
Maniphest T206029

VE does not provide If-Match for html/to/wikitext transforms sometimes
Closed, DuplicatePublic
Actions

Description

VE still does not provide the ETag of the original content back to html/to/wikitext endpoint If-Match header sometimes. See sample logs: https://logstash.wikimedia.org/goto/4b751b3fbf5de1044bd4255c693fc724

Judging by the frequency, it doesn't happen all the time, but only under certain circumstances. It does not break edits only because it relies on a very ugly fallback we have in RESTBase and are eager to remove (see parent task)

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT396539 Introduce a way to edit a span of text from within read mode
 OpenNoneT385558 Improve copy and paste from read mode to VE
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 OpenNoneT272987 [EPIC] Parsoid read views for DiscussionTools
 OpenNoneT297840 Populate ParserCache with Parsoid output as a post-edit hook
 OpenNoneT393717 Put lints in ParserOutput/RefreshLinksJob
 OpenBUG REPORTNoneT393682 Wikifunctions fragments that trigger errors and try to put the page in a tracking category show it at the bottom of the view page, but the pages using the fragment do not appear on the category page
 OpenNoneT409815 SLI: MediaWiki system load
 OpenNoneT393716 [EPIC] RefreshLinksJob should use Parsoid-generated metadata
 OpenNoneT310511 Metadata comparison testing between Parsoid and the legacy parser
 OpenNoneT310512 Parsoid and the legacy parser should emit exactly the same ParserOutput metadata
 OpenNoneT393925 Parsoid should generate the <head> on the core side, from the ParserOutput metadata
 OpenNoneT128525 Strip old metadata from old Parsoid content <head>: mw:TimeUuid, user, comment
 DuplicateNoneT206029 VE does not provide If-Match for html/to/wikitext transforms sometimes
 OpenNoneT331483 Resolve differences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content
 ResolvedcscottT213468 Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded
 ResolvedABreault-WMFT215628 Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use
 ResolvedcscottT214538 MediaWiki shouldn't assign section numbers during tokenization, but instead only when headings are generated
 OpencscottT359221 Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently
 ResolvedssastryT359450 Parsoid is not adding headings to TOC entries in some templated content scenarios
 ResolvedJgiannelosT402456 More Parsoid TOC edge cases?
 OpenJgiannelosT415554 From TOC difftesting (legacy/parsoid): Differences in template handling from sections
 OpenJgiannelosT415558 From TOC difftesting (legacy/parsoid): Mismatch when sections come from the same article
 OpenJgiannelosT415563 From TOC difftesting (legacy/parsoid): Inconsistent index level between legacy and parsoid
 OpenJgiannelosT415565 From TOC difftesting (legacy/parsoid): Section titles wrapped in html elements on parsoid
 ResolvedJgiannelosT403188 Implement TOC comparison in Linter extension

Event Timeline

• Pchelolo created this task.Oct 2 2018, 8:38 PM
• Pchelolo triaged this task as Medium priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 8:38 PM
• Pchelolo merged a task: T113728: VE should send If-Match header to the VRS to send on to RESTbase.Oct 3 2018, 3:42 PM
• Pchelolo added subscribers: • mobrovac, • AlexMonk-WMF, Esanders and 3 others.
• mobrovac added a project: Platform Team Workboards (Blocked Externally).Dec 20 2018, 12:47 PM
• mobrovac edited projects, added RESTBase-API, Services (watching), Platform Team Legacy (Watching / External); removed Platform Team Workboards (Blocked Externally), Services (blocked).Mar 14 2019, 12:58 AM
JTannerWMF moved this task from To Triage to FY 19-20 on the VisualEditor board.May 7 2019, 3:20 PM
JTannerWMF subscribed.

Hey @Pchelolo is this still blocking your work and if so how severely?

• Pchelolo added a comment.May 7 2019, 3:24 PM

It's is still the case sometimes. It's not severe, but we actually have a hack to insert an artificial meta tag with an article TID into Parsoid HTML in order to workaround this issue. It was added as temporary workaround many years ago and is becoming a permanent workaround, which is not good.

• mobrovac mentioned this in T233320: VisualEditor <-> RESTBase communication and ETags.Sep 19 2019, 3:05 PM
• mobrovac closed this task as a duplicate of T233320: VisualEditor <-> RESTBase communication and ETags.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits