Page MenuHomePhabricator
Create Task
Maniphest T206049

Gitiles project landing pages should have an anonymous clone URL
Closed, ResolvedPublic
Actions

Description

Upstream patch https://gerrit-review.googlesource.com/c/plugins/gitiles/+/163611

Visiting a Gitiles landing page like https://gerrit.wikimedia.org/g/mediawiki/extensions/SyntaxHighlight_GeSHi gives me an SSH clone URL like git clone ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi which is just not very useful. It should use the anonymous HTTPS URL (like git clone "https://gerrit.wikimedia.org/r/mediawiki/extensions/SyntaxHighlight_GeSHi"), or both. Compare https://gerrit.wikimedia.org/r/admin/projects/mediawiki/extensions/SyntaxHighlight_GeSHi which has those options.

(If the SSH URL is kept it should made easier to use - that's T189182: Gitiles should add username in git clone links, triggers "Permission denied (publickey)" error.)

Details

SubjectRepoBranchLines +/-
gerrit: add trailing slash to gerrit.canonicalWebUrloperations/puppetproduction+1 -1
gerrit: set gitiles clone url to http (Gerrit 3.6.2)operations/puppetproduction+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Oct 2 2018, 10:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 10:00 PM
Aklapper closed this task as a duplicate of T189182: Gitiles should add username in git clone links, triggers "Permission denied (publickey)" error.Jun 16 2020, 4:38 AM
Tgr added a comment.Jun 16 2020, 10:41 AM

How is this a duplicate? The other task is about SSH URLs, not HTTPS ones.

Aklapper added a comment.Jun 16 2020, 12:20 PM

@Tgr: Feel free to reopen and clarify in the task summaries

Tgr reopened this task as Open.Jun 16 2020, 1:57 PM
Tgr updated the task description. (Show Details)
Tgr updated the task description. (Show Details)Jun 16 2020, 1:59 PM
• ema triaged this task as High priority.Jul 22 2020, 2:27 PM
• ema subscribed.Jul 22 2020, 2:32 PM

Due to this issue I have so far been pointing people to the github mirrors of our repositories so that they can clone things and look around. Clearly not optimal.

QChris subscribed.Jul 22 2020, 9:52 PM

Yup, that's not good.

However, the URL can currently not be configured. It's hardwired to SSH, if SSH is available.

Not sure if anyone is working on it or planning to work on it. But the relevant code seems to be

https://gerrit.googlesource.com/plugins/gitiles/+/641476e153143c2b67e334b35626beb9b2534956/src/main/java/com/googlesource/gerrit/plugins/gitiles/Module.java#91

• ema added a comment.Jul 23 2020, 8:54 AM
In T206049#6328111, @QChris wrote:

However, the URL can currently not be configured. It's hardwired to SSH, if SSH is available.

Not sure if anyone is working on it or planning to work on it. But the relevant code seems to be

https://gerrit.googlesource.com/plugins/gitiles/+/641476e153143c2b67e334b35626beb9b2534956/src/main/java/com/googlesource/gerrit/plugins/gitiles/Module.java#91

Ah, thanks! HTTP seems like a more sensible default to me. Release-Engineering-Team: perhaps Module.java could be patched to change the default for us?

• ema added a project: Release-Engineering-Team.Jul 23 2020, 8:54 AM
thcipriani lowered the priority of this task from High to Low.Mar 16 2021, 4:33 PM
thcipriani edited projects, added Release-Engineering-Team-TODO, Upstream; removed Release-Engineering-Team.
thcipriani moved this task from Should be empty (use Release-Engineering-Team) to Later / Need volunteer on the Release-Engineering-Team-TODO board.
thcipriani edited projects, added Release-Engineering-Team (thcipriani-workboard-fiddling); removed Release-Engineering-Team-TODO.Apr 20 2021, 3:41 AM
thcipriani moved this task from thcipriani-workboard-fiddling to Seen (ARCHIVE) on the Release-Engineering-Team board.Apr 20 2021, 3:53 AM
thcipriani edited projects, added Release-Engineering-Team; removed Release-Engineering-Team (thcipriani-workboard-fiddling).
thcipriani edited projects, added Release-Engineering-Team (Seen); removed Release-Engineering-Team.Apr 20 2021, 3:23 PM
hashar updated the task description. (Show Details)May 21 2021, 11:55 AM
Aklapper moved this task from Backlog to Patch proposed upstream on the Upstream board.May 21 2021, 12:02 PM
hashar subscribed.May 21 2021, 12:10 PM

I think that is addressed by the pending Upstream patch https://gerrit-review.googlesource.com/c/plugins/gitiles/+/163611 . It introduces a new configuration variable:

The flag gerrit.cloneUrlType can be set to either ssh, http, or git. This will determine which protocol to be used to display repos' clone url to the user.
If it's not set, or it fails to get the set type of URL, it will automatically prefer SSH, then HTTP, then Git.

[gerrit]
  cloneUrlType = http

http would set the URL to gerrit.gitHttpUrl
git would use gerrit.canonicalGitUrl

We haven't those set, so I have suggested to also fall back to gerrit.canonicalWebUrl which on our setup is https://gerrit.wikimedia.org/r.

Push-f subscribed.Oct 22 2022, 9:49 AM

Can't we just set this new flag? I think it would be nice to address this unnecessary hurdle.

hashar edited projects, added Gerrit (Gerrit 3.6); removed Gerrit.Oct 22 2022, 8:28 PM
In T206049#8336797, @Push-f wrote:

Can't we just set this new flag? I think it would be nice to address this unnecessary hurdle.

The flag introduced by https://gerrit-review.googlesource.com/c/plugins/gitiles/+/163611 has been released with Gerrit 3.6.2 (we run 3.4 currently and I will upgrade to 3.5 soonish and hopefully to 3.6 soon after).

Aklapper added a project: Developer-Advocacy.Nov 30 2022, 9:44 AM

Also see T189182#8174367

Aklapper moved this task from To triage to Team radar on the Developer-Advocacy board.Nov 30 2022, 9:45 AM
Aklapper moved this task from Patch proposed upstream to Patch merged upstream on the Upstream board.
Aklapper merged a task: T189182: Gitiles should add username in git clone links, triggers "Permission denied (publickey)" error.
Aklapper added subscribers: TerraCodes, Lectrician1, Krinkle and 6 others.
gerritbot added a comment.Mar 27 2023, 2:08 PM

Change 903260 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] gerrit: set gitiles clone url to http (Gerrit 3.6.2)

https://gerrit.wikimedia.org/r/903260

gerritbot added a project: Patch-For-Review.Mar 27 2023, 2:08 PM
Krinkle awarded a token.Mar 27 2023, 6:10 PM
gerritbot added a comment.Mar 29 2023, 3:55 PM

Change 903260 merged by Dzahn:

[operations/puppet@production] gerrit: set gitiles clone url to http (Gerrit 3.6.2)

https://gerrit.wikimedia.org/r/903260

Maintenance_bot removed a project: Patch-For-Review.Mar 29 2023, 4:11 PM
Aklapper edited projects, added Developer Productivity; removed Developer-Advocacy.Apr 18 2023, 8:03 AM
Aklapper removed a subscriber: • ema.
Chlod subscribed.Apr 21 2023, 6:26 PM
hashar claimed this task.Jan 11 2024, 10:09 AM

I have upgraded to Gerrit 3.6.8. Gitiles now shows the https url but it is missing slash / between the base URL and the repository name :-\

gerrit_gitiles_clone_cmd.png (145×917 px, 21 KB)

gerritbot added a comment.Jan 11 2024, 10:30 AM

Change 989735 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] gerrit: add trailing slash to gerrit.canonicalWebUrl

https://gerrit.wikimedia.org/r/989735

gerritbot added a project: Patch-For-Review.Jan 11 2024, 10:30 AM
gerritbot added a comment.Jan 11 2024, 10:52 AM

Change 989735 merged by Jelto:

[operations/puppet@production] gerrit: add trailing slash to gerrit.canonicalWebUrl

https://gerrit.wikimedia.org/r/989735

Maintenance_bot removed a project: Patch-For-Review.Jan 11 2024, 11:30 AM
Stashbot added a comment.Jan 11 2024, 12:47 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-11T12:47:10Z] <hashar> Restarting Gerrit to apply config change https://gerrit.wikimedia.org/r/c/operations/puppet/+/989735/ # T206049

hashar closed this task as Resolved.Jan 11 2024, 12:52 PM

Fixed by adjusting gerrit.canonicalWebUrl to have a trailing /:

gerrit_gitiles_clone_cmd_fixed.png (145×917 px, 21 KB)

Lectrician1 awarded a token.Jan 11 2024, 1:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL