Page MenuHomePhabricator

Gitiles project landing pages should have an anonymous clone URL
Open, HighPublic

Description

Visiting a Gitiles landing page like https://gerrit.wikimedia.org/g/mediawiki/extensions/SyntaxHighlight_GeSHi gives me an SSH clone URL like git clone ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi which is just not very useful. It should use the anonymous HTTPS URL (like git clone "https://gerrit.wikimedia.org/r/mediawiki/extensions/SyntaxHighlight_GeSHi"), or both. Compare https://gerrit.wikimedia.org/r/admin/projects/mediawiki/extensions/SyntaxHighlight_GeSHi which has those options.

(If the SSH URL is kept it should made easier to use - that's T189182: Gitiles should add username in git clone links, triggers "Permission denied (publickey)" error.)

Event Timeline

Tgr created this task.Oct 2 2018, 10:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 10:00 PM
Tgr added a comment.Jun 16 2020, 10:41 AM

How is this a duplicate? The other task is about SSH URLs, not HTTPS ones.

@Tgr: Feel free to reopen and clarify in the task summaries

Tgr reopened this task as Open.Jun 16 2020, 1:57 PM
Tgr updated the task description. (Show Details)
Tgr updated the task description. (Show Details)Jun 16 2020, 1:59 PM
ema triaged this task as High priority.Jul 22 2020, 2:27 PM
ema added a subscriber: ema.Jul 22 2020, 2:32 PM

Due to this issue I have so far been pointing people to the github mirrors of our repositories so that they can clone things and look around. Clearly not optimal.

QChris added a subscriber: QChris.Jul 22 2020, 9:52 PM

Yup, that's not good.

However, the URL can currently not be configured. It's hardwired to SSH, if SSH is available.

Not sure if anyone is working on it or planning to work on it. But the relevant code seems to be

https://gerrit.googlesource.com/plugins/gitiles/+/641476e153143c2b67e334b35626beb9b2534956/src/main/java/com/googlesource/gerrit/plugins/gitiles/Module.java#91

ema added a comment.Jul 23 2020, 8:54 AM

However, the URL can currently not be configured. It's hardwired to SSH, if SSH is available.

Not sure if anyone is working on it or planning to work on it. But the relevant code seems to be

https://gerrit.googlesource.com/plugins/gitiles/+/641476e153143c2b67e334b35626beb9b2534956/src/main/java/com/googlesource/gerrit/plugins/gitiles/Module.java#91

Ah, thanks! HTTP seems like a more sensible default to me. Release-Engineering-Team: perhaps Module.java could be patched to change the default for us?