Page MenuHomePhabricator
Create Task
Maniphest T206100

Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

P7618 (An Untitled Masterwork)
122:37:25 There were 6 failures:
222:37:25
322:37:25 1) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchElastic with data set "simple" ('Duck', 'simple')
422:37:25 Failed asserting that two strings are equal.
522:37:25 --- Expected
622:37:25 +++ Actual
722:37:25 @@ @@
822:37:25 - "weight": 0.4\n
922:37:25 + "weight": 0.40000000000000002\n
1022:37:25 @@ @@
1122:37:25 - "weight": 0.6\n
1222:37:25 + "weight": 0.59999999999999998\n
1322:37:25
1422:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
1522:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:86
1622:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
1722:37:25 /workspace/src/maintenance/doMaintenance.php:94
1822:37:25
1922:37:25 2) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchElastic with data set "byid" ('(L2)', 'byid')
2022:37:25 Failed asserting that two strings are equal.
2122:37:25 --- Expected
2222:37:25 +++ Actual
2322:37:25 @@ @@
2422:37:25 - "weight": 0.4\n
2522:37:25 + "weight": 0.40000000000000002\n
2622:37:25 @@ @@
2722:37:25 - "weight": 0.6\n
2822:37:25 + "weight": 0.59999999999999998\n
2922:37:25
3022:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
3122:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:86
3222:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
3322:37:25 /workspace/src/maintenance/doMaintenance.php:94
3422:37:25
3522:37:25 3) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchFormElastic with data set "simple" ('Duck', 'simple')
3622:37:25 Failed asserting that two strings are equal.
3722:37:25 --- Expected
3822:37:25 +++ Actual
3922:37:25 @@ @@
4022:37:25 - "weight": 0.4\n
4122:37:25 + "weight": 0.40000000000000002\n
4222:37:25 @@ @@
4322:37:25 - "weight": 0.6\n
4422:37:25 + "weight": 0.59999999999999998\n
4522:37:25
4622:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
4722:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:105
4822:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
4922:37:25 /workspace/src/maintenance/doMaintenance.php:94
5022:37:25
5122:37:25 4) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchFormElastic with data set "byid" ('(L2)', 'byid')
5222:37:25 Failed asserting that two strings are equal.
5322:37:25 --- Expected
5422:37:25 +++ Actual
5522:37:25 @@ @@
5622:37:25 - "weight": 0.4\n
5722:37:25 + "weight": 0.40000000000000002\n
5822:37:25 @@ @@
5922:37:25 - "weight": 0.6\n
6022:37:25 + "weight": 0.59999999999999998\n
6122:37:25
6222:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
6322:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:105
6422:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
6522:37:25 /workspace/src/maintenance/doMaintenance.php:94
6622:37:25
6722:37:25 5) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeFullTextQueryBuilderTest::testSearchElastic with data set "work" ('duck', '/workspace/src/extensions/Wik...pected')
6822:37:25 Failed asserting that two strings are equal.
6922:37:25 --- Expected
7022:37:25 +++ Actual
7122:37:25 @@ @@
7222:37:25 - "boost": 0.1\n
7322:37:25 + "boost": 0.10000000000000001\n
7422:37:25 @@ @@
7522:37:25 - "boost": 0.1\n
7622:37:25 + "boost": 0.10000000000000001\n
7722:37:25 @@ @@
7822:37:25 - "weight": 0.4\n
7922:37:25 + "weight": 0.40000000000000002\n
8022:37:25 @@ @@
8122:37:25 - "weight": 0.6\n
8222:37:25 + "weight": 0.59999999999999998\n
8322:37:25
8422:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
8522:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeFullTextQueryBuilderTest.php:97
8622:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
8722:37:25 /workspace/src/maintenance/doMaintenance.php:94
8822:37:25
8922:37:25 6) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeFullTextQueryBuilderTest::testSearchElastic with data set "id" (' L2-F1 ', '/workspace/src/extensions/Wik...pected')
9022:37:25 Failed asserting that two strings are equal.
9122:37:25 --- Expected
9222:37:25 +++ Actual
9322:37:25 @@ @@
9422:37:25 - "boost": 0.1\n
9522:37:25 + "boost": 0.10000000000000001\n
9622:37:25 @@ @@
9722:37:25 - "boost": 0.1\n
9822:37:25 + "boost": 0.10000000000000001\n
9922:37:25 @@ @@
10022:37:25 - "weight": 0.4\n
10122:37:25 + "weight": 0.40000000000000002\n
10222:37:25 @@ @@
10322:37:25 - "weight": 0.6\n
10422:37:25 + "weight": 0.59999999999999998\n
10522:37:25
10622:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
10722:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeFullTextQueryBuilderTest.php:97
10822:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
10922:37:25 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/1/console

Can be verified by commenting "check experimental" in Gerrit to trigger the PHP 7.1 jobs. T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1 appears nearly identical. Looks to be caused by https://wiki.php.net/rfc/precise_float_value.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexemeREL1_31+1 -1Use the same precision as in T205958
mediawiki/extensions/WikibaseLexemeREL1_31+5 -0Set serialize_precision to fix tests on PHP 7.1+
mediawiki/extensions/WikibaseLexememaster+2 -6Use the same precision as in T205958
mediawiki/extensions/WikibaseLexememaster+17 -0Set serialize_precision to fix tests on PHP 7.1+
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Oct 3 2018, 5:45 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 3 2018, 5:45 AM
Legoktm added a parent task: T204884: Run MediaWiki tests on PHP 7.3.Oct 3 2018, 5:45 AM
Smalyshev added a subscriber: Smalyshev.Oct 3 2018, 8:13 PM
Legoktm moved this task from Backlog to Wikimedia production on the PHP 7.1 support board.Oct 5 2018, 5:20 AM
thiemowmde added a project: Elasticsearch.Oct 8 2018, 7:39 AM
thiemowmde added subscribers: • Addshore, WMDE-leszek.
Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 8 2018, 7:39 AM
• Addshore added a project: wdwb-tech.Oct 8 2018, 11:15 AM
• Addshore moved this task from Inbox to CI & Testing on the wdwb-tech board.Oct 8 2018, 12:39 PM
• Addshore moved this task from incoming to ready to go on the Wikidata board.Oct 8 2018, 1:03 PM
Smalyshev added a project: User-Smalyshev.Oct 9 2018, 12:50 AM
WMDE-leszek added a project: Wikidata-Campsite.Oct 9 2018, 10:24 AM
WMDE-leszek moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
• Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 9 2018, 1:07 PM
• Addshore set the point value for this task to 3.
• Addshore triaged this task as High priority.Oct 9 2018, 1:43 PM
• Addshore moved this task from Ready to estimate to In Progress on the Wikidata-Campsite board.Oct 9 2018, 1:47 PM
Ladsgroup claimed this task.Oct 9 2018, 3:12 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptOct 9 2018, 3:12 PM
gerritbot added a subscriber: gerritbot.Oct 9 2018, 3:48 PM

Change 465443 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Add JSON_NUMERIC_CHECK to json_encode

https://gerrit.wikimedia.org/r/465443

gerritbot added a project: Patch-For-Review.Oct 9 2018, 3:48 PM
Ladsgroup mentioned this in rEWLEe420975a0b78: Add JSON_NUMERIC_CHECK to json_encode.Oct 9 2018, 3:49 PM
Jdforrester-WMF mentioned this in T206281: Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException fails on PHP 7.1.Oct 9 2018, 3:58 PM
Ladsgroup mentioned this in rEWLE534b67419072: Set serialize_precision.Oct 9 2018, 6:17 PM
Smalyshev removed a project: User-Smalyshev.Oct 9 2018, 6:40 PM
Smalyshev mentioned this in T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1.Oct 9 2018, 6:42 PM
Ladsgroup mentioned this in rEWLEf785f46fca98: Set serialize_precision.Oct 9 2018, 6:47 PM
Ladsgroup mentioned this in rEWLE74274a6b2bb7: Set serialize_precision.Oct 9 2018, 7:09 PM
Legoktm mentioned this in rEWLE206f7e377510: Set serialize_precision to fix tests on PHP 7.1+.Oct 10 2018, 3:44 AM
gerritbot added a comment.Oct 10 2018, 4:20 AM

Change 465443 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Set serialize_precision to fix tests on PHP 7.1+

https://gerrit.wikimedia.org/r/465443

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 10 2018, 5:00 AM
WMDE-leszek moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 10 2018, 10:07 AM
WMDE-leszek moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Legoktm closed this task as Resolved.Oct 10 2018, 5:34 PM

Follow-up work is ongoing, but this is fixed now.

• Addshore moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 12 2018, 8:26 AM
gerritbot added a comment.Oct 12 2018, 8:49 PM

Change 466982 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@master] Use the same precision as in T205958

https://gerrit.wikimedia.org/r/466982

Diffusion mentioned this in rEWLE833eb9f41149: Use the same precision as in T205958.Oct 12 2018, 8:50 PM
gerritbot added a comment.Oct 12 2018, 10:41 PM

Change 466982 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use the same precision as in T205958

https://gerrit.wikimedia.org/r/466982

• Addshore removed a project: Wikidata-Campsite.Nov 1 2018, 11:21 AM
gerritbot added a comment.Jan 1 2021, 7:15 PM

Change 653148 had a related patch set uploaded (by Umherirrender; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@REL1_31] Set serialize_precision to fix tests on PHP 7.1+

https://gerrit.wikimedia.org/r/653148

gerritbot added a comment.Jan 1 2021, 8:19 PM

Change 653148 merged by Umherirrender:
[mediawiki/extensions/WikibaseLexeme@REL1_31] Set serialize_precision to fix tests on PHP 7.1+

https://gerrit.wikimedia.org/r/653148

Maintenance_bot removed a project: Patch-For-Review.Jan 1 2021, 9:10 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 1 2021, 9:15 PM
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.
gerritbot added a comment.Jan 2 2021, 5:25 PM

Change 653472 had a related patch set uploaded (by Umherirrender; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@REL1_31] Use the same precision as in T205958

https://gerrit.wikimedia.org/r/653472

gerritbot added a project: Patch-For-Review.Jan 2 2021, 5:25 PM
gerritbot added a comment.Jan 2 2021, 5:54 PM

Change 653472 merged by Umherirrender:
[mediawiki/extensions/WikibaseLexeme@REL1_31] Use the same precision as in T205958

https://gerrit.wikimedia.org/r/653472

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL