Maniphest T206100

Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

1	22:37:25 There were 6 failures:
2	22:37:25
3	22:37:25 1) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchElastic with data set "simple" ('Duck', 'simple')
4	22:37:25 Failed asserting that two strings are equal.
5	22:37:25 --- Expected
6	22:37:25 +++ Actual
7	22:37:25 @@ @@
8	22:37:25 - "weight": 0.4\n
9	22:37:25 + "weight": 0.40000000000000002\n
10	22:37:25 @@ @@
11	22:37:25 - "weight": 0.6\n
12	22:37:25 + "weight": 0.59999999999999998\n
13	22:37:25
14	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
15	22:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:86
16	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
17	22:37:25 /workspace/src/maintenance/doMaintenance.php:94
18	22:37:25
19	22:37:25 2) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchElastic with data set "byid" ('(L2)', 'byid')
20	22:37:25 Failed asserting that two strings are equal.
21	22:37:25 --- Expected
22	22:37:25 +++ Actual
23	22:37:25 @@ @@
24	22:37:25 - "weight": 0.4\n
25	22:37:25 + "weight": 0.40000000000000002\n
26	22:37:25 @@ @@
27	22:37:25 - "weight": 0.6\n
28	22:37:25 + "weight": 0.59999999999999998\n
29	22:37:25
30	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
31	22:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:86
32	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
33	22:37:25 /workspace/src/maintenance/doMaintenance.php:94
34	22:37:25
35	22:37:25 3) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchFormElastic with data set "simple" ('Duck', 'simple')
36	22:37:25 Failed asserting that two strings are equal.
37	22:37:25 --- Expected
38	22:37:25 +++ Actual
39	22:37:25 @@ @@
40	22:37:25 - "weight": 0.4\n
41	22:37:25 + "weight": 0.40000000000000002\n
42	22:37:25 @@ @@
43	22:37:25 - "weight": 0.6\n
44	22:37:25 + "weight": 0.59999999999999998\n
45	22:37:25
46	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
47	22:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:105
48	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
49	22:37:25 /workspace/src/maintenance/doMaintenance.php:94
50	22:37:25
51	22:37:25 4) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest::testSearchFormElastic with data set "byid" ('(L2)', 'byid')
52	22:37:25 Failed asserting that two strings are equal.
53	22:37:25 --- Expected
54	22:37:25 +++ Actual
55	22:37:25 @@ @@
56	22:37:25 - "weight": 0.4\n
57	22:37:25 + "weight": 0.40000000000000002\n
58	22:37:25 @@ @@
59	22:37:25 - "weight": 0.6\n
60	22:37:25 + "weight": 0.59999999999999998\n
61	22:37:25
62	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
63	22:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeCompletionSearchTest.php:105
64	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
65	22:37:25 /workspace/src/maintenance/doMaintenance.php:94
66	22:37:25
67	22:37:25 5) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeFullTextQueryBuilderTest::testSearchElastic with data set "work" ('duck', '/workspace/src/extensions/Wik...pected')
68	22:37:25 Failed asserting that two strings are equal.
69	22:37:25 --- Expected
70	22:37:25 +++ Actual
71	22:37:25 @@ @@
72	22:37:25 - "boost": 0.1\n
73	22:37:25 + "boost": 0.10000000000000001\n
74	22:37:25 @@ @@
75	22:37:25 - "boost": 0.1\n
76	22:37:25 + "boost": 0.10000000000000001\n
77	22:37:25 @@ @@
78	22:37:25 - "weight": 0.4\n
79	22:37:25 + "weight": 0.40000000000000002\n
80	22:37:25 @@ @@
81	22:37:25 - "weight": 0.6\n
82	22:37:25 + "weight": 0.59999999999999998\n
83	22:37:25
84	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
85	22:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeFullTextQueryBuilderTest.php:97
86	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
87	22:37:25 /workspace/src/maintenance/doMaintenance.php:94
88	22:37:25
89	22:37:25 6) Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeFullTextQueryBuilderTest::testSearchElastic with data set "id" (' L2-F1 ', '/workspace/src/extensions/Wik...pected')
90	22:37:25 Failed asserting that two strings are equal.
91	22:37:25 --- Expected
92	22:37:25 +++ Actual
93	22:37:25 @@ @@
94	22:37:25 - "boost": 0.1\n
95	22:37:25 + "boost": 0.10000000000000001\n
96	22:37:25 @@ @@
97	22:37:25 - "boost": 0.1\n
98	22:37:25 + "boost": 0.10000000000000001\n
99	22:37:25 @@ @@
100	22:37:25 - "weight": 0.4\n
101	22:37:25 + "weight": 0.40000000000000002\n
102	22:37:25 @@ @@
103	22:37:25 - "weight": 0.6\n
104	22:37:25 + "weight": 0.59999999999999998\n
105	22:37:25
106	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:2265
107	22:37:25 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Search/LexemeFullTextQueryBuilderTest.php:97
108	22:37:25 /workspace/src/tests/phpunit/MediaWikiTestCase.php:409
109	22:37:25 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/1/console

Can be verified by commenting "check experimental" in Gerrit to trigger the PHP 7.1 jobs. T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1 appears nearly identical. Looks to be caused by https://wiki.php.net/rfc/precise_float_value.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikibaseLexeme	master	+2 -6	Use the same precision as in T205958
	mediawiki/extensions/WikibaseLexeme	master	+17 -0	Set serialize_precision to fix tests on PHP 7.1+

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T204884 Run MediaWiki tests on PHP 7.3
		Resolved		Ladsgroup	T206100 Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1

Event Timeline

Legoktm created this task.Oct 3 2018, 5:45 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 3 2018, 5:45 AM

Legoktm added a parent task: T204884: Run MediaWiki tests on PHP 7.3.Oct 3 2018, 5:45 AM

Smalyshev added a subscriber: Smalyshev.Oct 3 2018, 8:13 PM

Legoktm moved this task from Backlog to Wikimedia production on the PHP 7.1 support board.Oct 5 2018, 5:20 AM

thiemowmde added a project: Elasticsearch.Oct 8 2018, 7:39 AM

thiemowmde added subscribers: Addshore, WMDE-leszek.

Restricted Application added a project: Discovery-Search. · View Herald TranscriptOct 8 2018, 7:39 AM

Addshore added a project: wikidata-tech-focus.Oct 8 2018, 11:15 AM

Addshore moved this task from Backlog to CI & Testing on the wikidata-tech-focus board.Oct 8 2018, 12:39 PM

Addshore moved this task from incoming to ready to go on the Wikidata board.Oct 8 2018, 1:03 PM

Smalyshev added a project: User-Smalyshev.Oct 9 2018, 12:50 AM

WMDE-leszek added a project: Wikidata-Campsite.Oct 9 2018, 10:24 AM

WMDE-leszek moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).Oct 9 2018, 1:07 PM

Addshore set the point value for this task to 3.

Addshore triaged this task as High priority.Oct 9 2018, 1:43 PM

Addshore moved this task from Ready to estimate to In Progress on the Wikidata-Campsite board.Oct 9 2018, 1:47 PM

Ladsgroup claimed this task.Oct 9 2018, 3:12 PM

Ladsgroup moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptOct 9 2018, 3:12 PM

Change 465443 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Add JSON_NUMERIC_CHECK to json_encode

https://gerrit.wikimedia.org/r/465443

gerritbot added a project: Patch-For-Review.Oct 9 2018, 3:48 PM

Ladsgroup mentioned this in rEWLEe420975a0b78: Add JSON_NUMERIC_CHECK to json_encode.Oct 9 2018, 3:49 PM

Jdforrester-WMF mentioned this in T206281: Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException fails on PHP 7.1.Oct 9 2018, 3:58 PM

Ladsgroup mentioned this in rEWLE534b67419072: Set serialize_precision.Oct 9 2018, 6:17 PM

Smalyshev removed a project: User-Smalyshev.Oct 9 2018, 6:40 PM

Smalyshev mentioned this in T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1.Oct 9 2018, 6:42 PM

Ladsgroup mentioned this in rEWLEf785f46fca98: Set serialize_precision.Oct 9 2018, 6:47 PM

Ladsgroup mentioned this in rEWLE74274a6b2bb7: Set serialize_precision.Oct 9 2018, 7:09 PM

Legoktm mentioned this in rEWLE206f7e377510: Set serialize_precision to fix tests on PHP 7.1+.Oct 10 2018, 3:44 AM

Change 465443 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Set serialize_precision to fix tests on PHP 7.1+

https://gerrit.wikimedia.org/r/465443

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 10 2018, 5:00 AM

WMDE-leszek moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Oct 10 2018, 10:07 AM

WMDE-leszek moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Follow-up work is ongoing, but this is fixed now.

Addshore moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Oct 12 2018, 8:26 AM

Change 466982 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@master] Use the same precision as in T205958

https://gerrit.wikimedia.org/r/466982

Diffusion mentioned this in rEWLE833eb9f41149: Use the same precision as in T205958.Oct 12 2018, 8:50 PM

Change 466982 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use the same precision as in T205958

https://gerrit.wikimedia.org/r/466982

Addshore removed a project: Wikidata-Campsite.Nov 1 2018, 11:21 AM