Maniphest T206138

[EPIC] Increase test coverage for VE.ce code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• marcella
	Oct 3 2018, 4:10 PM

Description

Increase test coverage within ve.ce code to a total of 80%.
Coverage as of Oct 3:

Total	74.85%	3569/4768
src/ce/	73.65%	2382/3234
src/ce/annotations/	95.96%	214/223
src/ce/keydownhandlers/	74.56%	299/401
src/ce/nodes/	78.26%	594/759
src/ce/selections/	52.98%	80/151

Edit: After removing some false coverage, this was found to be:

Total	74.64%	3559/4768
src/ce/	73.44%	2375/3234
src/ce/annotations/	95.96%	214/223
src/ce/keydownhandlers/	74.56%	299/401
src/ce/nodes/	78.26%	594/759
src/ce/selections/	50.99%	77/151

Related Objects
Search...

Status	Assigned	Task
Resolved	• marcella	T206138 [EPIC] Increase test coverage for VE.ce code
Resolved	Esanders	T207077 Increase unit test coverage in ve.ce.LinearArrowKeyDownHandler
Resolved	Esanders	T207078 Increase unit test coverage in ve.ce.LinearDeleteKeyDownHandler
Resolved	Esanders	T207079 Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler
Resolved	Esanders	T207080 Increase unit test coverage in ve/ce/KeyDownHandlers : LinearEscape, LinearTab, TableArrow, TableDelete, TableEnter
Declined	None	T207082 Research adding test coverage to ve.ce.Surface
Resolved	Esanders	T207083 Investigation spike to add test coverage for ve.ce.FocusableNode
Declined	None	T207084 Increase unit test coverage in ve.ce.GeneratedContentNode
Resolved	DLynch	T130389 ve.ce.LinearArrowKeyDownHandler.js is largely untested
Resolved	Esanders	T207287 Separate *KeyDownHandler tests into separate files
Resolved	Esanders	T208396 Add basic coverage for Dialog/Inspector opening in UI
Resolved	DLynch	T208515 Improve test coverage for ve.ce.ResizableNode
Resolved	Esanders	T217957 Add functional test coverage for link inspector and others

Event Timeline

• marcella created this task.Oct 3 2018, 4:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2018, 4:10 PM

• marcella moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Oct 3 2018, 4:11 PM

JTannerWMF moved this task from FY 18-19 Q3/Q4 to Current work on the VisualEditor board.Oct 3 2018, 4:52 PM

JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.

• marcella claimed this task.Oct 3 2018, 4:52 PM

I think our proposal for the quarter was just to get CE to 80%, the other two are probably a lot further off and are better covered by browser tests.

In T206138#4640312, @Esanders wrote:

I think our proposal for the quarter was just to get CE to 80%, the other two are probably a lot further off and are better covered by browser tests.

Thanks Ed--adjusted properly and will make sure that's reflected in the quarterly goals as well.

Current coverage report: https://doc.wikimedia.org/cover/visualeditor/src/ce/

doc.wikimedia.org_cover_visualeditor_src_ce_(Laptop with MDPI screen).png (1×1 px, 140 KB)

• marcella added a subtask: T207077: Increase unit test coverage in ve.ce.LinearArrowKeyDownHandler.Oct 15 2018, 7:34 PM

• marcella added a subtask: T130389: ve.ce.LinearArrowKeyDownHandler.js is largely untested.Oct 15 2018, 7:58 PM

In T206138#4667309, @matmarex wrote:

Current coverage report: https://doc.wikimedia.org/cover/visualeditor/src/ce/

Due to way Istanbul flattens directories, that link only shows files immediately in src/ce. There are four subfolders we should include as well: https://doc.wikimedia.org/cover/visualeditor/index.html