Page MenuHomePhabricator

[EPIC] Increase test coverage for VE.ce code
Open, Needs TriagePublic

Description

Increase test coverage within ve.ce code to a total of 80%.
Coverage as of Oct 3:

Total74.85%3569/4768
src/ce/73.65%2382/3234
src/ce/annotations/95.96%214/223
src/ce/keydownhandlers/74.56%299/401
src/ce/nodes/78.26%594/759
src/ce/selections/52.98%80/151

Edit: After removing some false coverage, this was found to be:

Total74.64%3559/4768
src/ce/73.44%2375/3234
src/ce/annotations/95.96%214/223
src/ce/keydownhandlers/74.56%299/401
src/ce/nodes/78.26%594/759
src/ce/selections/50.99%77/151

Event Timeline

marcella created this task.Oct 3 2018, 4:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2018, 4:10 PM
marcella moved this task from To Triage to Q4 on the VisualEditor board.Oct 3 2018, 4:11 PM
JTannerWMF moved this task from Q4 to Current work on the VisualEditor board.Oct 3 2018, 4:52 PM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.
marcella claimed this task.Oct 3 2018, 4:52 PM
Esanders updated the task description. (Show Details)Oct 3 2018, 9:48 PM
Esanders added a subscriber: Esanders.

I think our proposal for the quarter was just to get CE to 80%, the other two are probably a lot further off and are better covered by browser tests.

marcella renamed this task from [EPIC] Increase test coverage for VE code to [EPIC] Increase test coverage for VE.ce code.Oct 6 2018, 1:27 AM
marcella updated the task description. (Show Details)

I think our proposal for the quarter was just to get CE to 80%, the other two are probably a lot further off and are better covered by browser tests.

Thanks Ed--adjusted properly and will make sure that's reflected in the quarterly goals as well.

Due to way Istanbul flattens directories, that link only shows files immediately in src/ce. There are four subfolders we should include as well: https://doc.wikimedia.org/cover/visualeditor/index.html

Esanders updated the task description. (Show Details)Oct 20 2018, 4:01 PM

After keydown tests improvements, CE coverage is at 3695/4762 (77.59%)

Esanders updated the task description. (Show Details)Oct 23 2018, 10:25 AM

Master is now at 3723/4728 (78.74%)

Esanders added a comment.EditedNov 1 2018, 9:31 PM

3785/4742 (79.82%)

Now 3876/4745 (81.69%) 🎉🎉🎉

JTannerWMF moved this task from To Triage to Epics on the VisualEditor board.