Page MenuHomePhabricator
Create Task
Maniphest T206161

Spike in fatals from WikiPageEntityMetaDataLookup during group1 deployment of 1.32.0-wmf.24
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

From fatalmonitor:

223 Catchable fatal error: Argument 2 passed to Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup::__construct() must be an instance
of MediaWiki\Storage\NameTableStore, undefined variable given in /srv/mediawiki/php-1.32.0-wmf.24/extensions/WikibaseQualityConstraints/src
/ServiceWiring.php on line 249
222 Warning: __construct() expects at least 2 parameters, 1 given in /srv/mediawiki/php-1.32.0-wmf.24/extensions/Wikibase/lib/includes/
Store/Sql/WikiPageEntityMetaDataLookup.php on line 56

Apparent spike in logstash:
https://logstash.wikimedia.org/goto/c6a8dbbcfa541bc41f1c7a533d02fcec

Details

SubjectRepoBranchLines +/-
Fix WikiPageEntityMetaDataLookup constructionmediawiki/extensions/WikibaseQualityConstraintsmaster+4 -1
Fix WikiPageEntityMetaDataLookup constructionmediawiki/extensions/WikibaseQualityConstraintswmf/1.32.0-wmf.24+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• dduvall removed • dduvall as the assignee of this task.Oct 3 2018, 7:30 PM
• dduvall triaged this task as High priority.
• dduvall created this task.
Addshore claimed this task.Oct 3 2018, 7:30 PM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Restricted Application added a project: User-Addshore. · View Herald TranscriptOct 3 2018, 7:30 PM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 3 2018, 7:31 PM
greg raised the priority of this task from High to Unbreak Now!.Oct 3 2018, 7:42 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 3 2018, 7:42 PM
Addshore added a comment.Oct 3 2018, 7:51 PM

WikibaseQualityConstraints makes its own WikiPageEntityMetaDataLookup instance rather than using one from WikibaseServices.
WikiPageEntityMetaDataLookup isn't actually exposed in WikibaseServices yet, only the EntityPrefetcher interfaces is....

Krinkle renamed this task from Spike in fatals during group1 deployment of 1.32.0-wmf.24 to Spike in fatals from WikiPageEntityMetaDataLookup during group1 deployment of 1.32.0-wmf.24.Oct 3 2018, 7:54 PM
Krinkle added a project: Wikimedia-production-error.
Krinkle moved this task from Untriaged to Jun 2019 / 1.34.wmf.8+ on the Wikimedia-production-error board.
greg removed projects: Release-Engineering-Team (Kanban), Release, Train Deployments.Oct 3 2018, 7:56 PM
gerritbot subscribed.Oct 3 2018, 8:06 PM

Change 464405 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix WikiPageEntityMetaDataLookup construction

https://gerrit.wikimedia.org/r/464405

gerritbot added a project: Patch-For-Review.Oct 3 2018, 8:06 PM

Change 464407 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.32.0-wmf.24] Fix WikiPageEntityMetaDataLookup construction

https://gerrit.wikimedia.org/r/464407

Addshore mentioned this in T206164: WikibaseQualityConstraints should not construct Wikibase services itself..Oct 3 2018, 8:11 PM
Stashbot subscribed.Oct 3 2018, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-03T20:28:49Z] <marxarelli> deployed proposed WikibaseQualityConstraints fix and wikiversions bump for wikidatawiki to mwdebug1001 and mwdebug1002 for verification (T206161)

gerritbot added a comment.Oct 3 2018, 9:08 PM

Change 464407 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.32.0-wmf.24] Fix WikiPageEntityMetaDataLookup construction

https://gerrit.wikimedia.org/r/464407

Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald TranscriptOct 3 2018, 9:08 PM
gerritbot added a comment.Oct 3 2018, 9:10 PM

Change 464405 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix WikiPageEntityMetaDataLookup construction

https://gerrit.wikimedia.org/r/464405

Stashbot added a comment.Oct 3 2018, 9:12 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-03T21:12:18Z] <dduvall@deploy1001> Synchronized php-1.32.0-wmf.24/extensions/WikibaseQualityConstraints/src/ServiceWiring.php: deploying fix to 1.32.0-wmf.24 for T206161 (duration: 00m 57s)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 3 2018, 10:00 PM
Addshore closed this task as Resolved.Oct 4 2018, 8:24 AM
Addshore added a project: Wikidata.
Addshore moved this task from Doing to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore mentioned this in T206205: WBQC_ResultsSource ConstraintsServices not tested in CI for WikibaseQualityConstraints.Oct 4 2018, 10:18 AM
Liuxinyu970226 unsubscribed.Oct 4 2018, 2:14 PM
Krinkle removed a project: Patch-For-Review.Oct 10 2018, 8:42 PM
Krinkle moved this task from Jun 2019 / 1.34.wmf.8+ to Resolved on the Wikimedia-production-error board.Jan 22 2019, 3:08 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL