Maniphest T206164

WikibaseQualityConstraints should not construct Wikibase services itself.
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

In ServiceWiring.php WikibaseQualityConstraints constructs a WikiPageEntityMetaDataLookup.

WikibaseServices should provide a way for get an pre constructed WikiPageEntityMetaDataLookup and WikibaseQualityConstraints should use that.

The fact that QC creates its own service was missed in some recent changes (and apparently not caught by CI) and caused T206161

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikibaseQualityConstraints	master	+1 -12	Use new Wikibase service instead of recreating it
	mediawiki/extensions/Wikibase	master	+18 -0	Provide WikiPageEntityMetaDataLookup as a Service

Customize query in gerrit

Related Objects

Mentioned In: T277489: Move WikibaseRepo LocalRepoWikipageMetaDataAccessor to service container
T207394: Argument 2 passed to Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup::__construct() must implement interface Wikibase\Lib\Store\Sql\PageTableEntityQuery, MediaWiki\Storage\NameTableStore given in /srv/mediawiki/php-1.32.0-wmf.26/extensions/WikibaseQualityConstraints/src/ServiceWiring.php on line 254
Mentioned Here: T206161: Spike in fatals from WikiPageEntityMetaDataLookup during group1 deployment of 1.32.0-wmf.24

Event Timeline

• Addshore created this task.Oct 3 2018, 8:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2018, 8:11 PM

Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.Oct 4 2018, 9:35 AM

• Addshore moved this task from Inbox to Small Code Fixes on the wdwb-tech board.Oct 8 2018, 12:50 PM

• Addshore triaged this task as Low priority.Oct 8 2018, 1:00 PM

• Addshore moved this task from incoming to ready to go on the Wikidata board.Oct 8 2018, 1:03 PM

• Addshore added a project: Wikidata-Campsite.Oct 16 2018, 12:42 PM

• Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

• Addshore raised the priority of this task from Low to High.Oct 18 2018, 4:13 PM

• Addshore mentioned this in T207394: Argument 2 passed to Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup::__construct() must implement interface Wikibase\Lib\Store\Sql\PageTableEntityQuery, MediaWiki\Storage\NameTableStore given in /srv/mediawiki/php-1.32.0-wmf.26/extensions/WikibaseQualityConstraints/src/ServiceWiring.php on line 254.

@Tarrow and I estimated this just now was a 5 and will bring it into the campsite iteration now

• Addshore moved this task from ready to go to in progress on the Wikidata board.Oct 18 2018, 4:23 PM

• Addshore edited projects, added Technical-Debt; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 31 2018, 4:31 PM

This was already on the campsite iteration, but it was removed when we made it a sub project, so re adding now!

Apparently the story points also got lost...

I’m confused by the Wikibase service wiring. For WBQC, we store all services in the MediaWiki service container. Apparently Wikibase doesn’t do that, but has its own container? That seems to complicate the interaction between WBQC and Wikibase :/

Michael claimed this task.Nov 12 2018, 5:02 PM

Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 473054 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Provide WikiPageEntityMetaDataLookup as a Service

https://gerrit.wikimedia.org/r/473054

gerritbot added a project: Patch-For-Review.Nov 12 2018, 6:01 PM

Change 473055 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use new Wikibase service instead of recreating it

https://gerrit.wikimedia.org/r/473055

Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 14 2018, 10:50 AM

• Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 14 2018, 4:32 PM

Change 473054 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Provide WikiPageEntityMetaDataLookup as a Service

https://gerrit.wikimedia.org/r/473054

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 6:00 PM

Change 473055 had a related patch set uploaded (by Jforrester; owner: Michael Große):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use new Wikibase service instead of recreating it

https://gerrit.wikimedia.org/r/473055

Change 473055 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use new Wikibase service instead of recreating it

https://gerrit.wikimedia.org/r/473055

• Addshore closed this task as Resolved.Nov 15 2018, 1:06 PM

• Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Lucas_Werkmeister_WMDE mentioned this in T277489: Move WikibaseRepo LocalRepoWikipageMetaDataAccessor to service container.Mar 30 2021, 3:04 PM