Page MenuHomePhabricator

vendor: Drop need for explicit demand on pear/net_socket by upgrading to pear/net_smtp 1.8.1
Closed, ResolvedPublic

Description

Yay https://github.com/pear/Net_SMTP/issues/24 only three years later (via @demon).

Related Objects

Event Timeline

Jdforrester-WMF created this task.

We have pear/net_smtp 1.8.1 - https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json#L43

So patch incoming

Is this meaning in MW core? As if so, there is no pear/net_socket (anymore?) in composer.json

But obviously we still want it explicitly in vendor/composer.json

Yeah, just vendor, hence the tag. ;-)

We explicitly tag in vendors compare.json. Including dependencies

I don’t see what’s still to do here

Jdforrester-WMF assigned this task to Reedy.

Yeah, looks like you resolved this with ce870c9c0. Thanks.