Page MenuHomePhabricator
Create Task
Maniphest T206179

Feature flag the page issues code
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

precursors

Coordinate with whoever is working on T206178

In preparation for shipping the page issues code, we should add a feature flag.

NOTE: This can be done in the feature branch OR master depending on progress in T208514

Acceptance criteria

  • Feature flag is disabled in production stable by default
  • Beta users see the new treatment
  • query override always get me new treatment

Sign off steps

Make sure a card exists for merging the feature branch

QA steps

Details

ProjectBranchLines +/-Subject
mediawiki/skins/MinervaNeuemaster+38 -5page issues is feature flagged
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Oct 3 2018, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2018, 10:23 PM
Jdlrobson mentioned this in T206178: Feature branch: Remove pageIssues A-B test code.Oct 4 2018, 3:21 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson triaged this task as High priority.Oct 8 2018, 9:03 PM
ovasileva moved this task from Triaged but Future to Upcoming on the Readers-Web-Backlog board.Oct 9 2018, 3:52 PM
• Tbayer added a subscriber: • Tbayer.Oct 9 2018, 4:23 PM
ovasileva set the point value for this task to 3.Oct 9 2018, 4:27 PM
Jdlrobson added a comment.Oct 16 2018, 10:02 PM

Note: this should be considered a blocker from a technical POV for deployment. We'll be making some follow up changes as part of cleanup so we'll want 100% control of the release of this feature.

ovasileva renamed this task from Feature flag the page issues code to Feature branch: Feature flag the page issues code.Oct 17 2018, 5:20 PM
ovasileva edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Readers-Web-Backlog.
ovasileva updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Oct 17 2018, 5:22 PM
Jdlrobson mentioned this in T208514: Merge PageIssues Feature Branch to Master.Nov 2 2018, 3:14 PM
Jdlrobson renamed this task from Feature branch: Feature flag the page issues code to Feature flag the page issues code.Nov 8 2018, 5:59 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 12 2018, 7:08 PM
Jdlrobson updated the task description. (Show Details)Nov 12 2018, 8:34 PM
gerritbot added a subscriber: gerritbot.Nov 12 2018, 8:35 PM

Change 473080 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] page issues is feature flagged

https://gerrit.wikimedia.org/r/473080

gerritbot added a project: Patch-For-Review.Nov 12 2018, 8:35 PM
Jdlrobson moved this task from Doing to Needs Design Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 12 2018, 8:35 PM
Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 12 2018, 11:01 PM
Jdlrobson mentioned this in T206647: Prepare selenium browser test for page issues A/B test.Nov 16 2018, 6:32 PM
ovasileva moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 19 2018, 6:14 PM
Jdlrobson moved this task from Needs More Work to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 20 2018, 6:08 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 20 2018, 8:15 PM
gerritbot added a comment.Nov 20 2018, 10:44 PM

Change 473080 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] page issues is feature flagged

https://gerrit.wikimedia.org/r/473080

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 20 2018, 10:51 PM
Jdlrobson moved this task from Ready for Signoff to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 20 2018, 11:00 PM
Jdlrobson assigned this task to ABorbaWMF.Nov 20 2018, 11:37 PM
Jdlrobson updated the task description. (Show Details)
ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Nov 27 2018, 12:18 AM

Looks good to me on staging

oldnew
ovasileva closed this task as Resolved.Nov 27 2018, 6:41 PM
ovasileva added a subscriber: ovasileva.

all done!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL