Maniphest T206236

Dimensions widget inputs are unnecessarily large
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Oct 4 2018, 3:57 PM

Description

The dimensions widget has very large inputs, causing awkward wrapping in the graph dialog:

This amount of space is unnecessary given that the numbers entered are unlikely to be more than 4 digits long.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (f9afaa3e4)	mediawiki/extensions/VisualEditor	master	+5 -7
	Minor cleanup of ve.ui.MediaSizeWidget	VisualEditor/VisualEditor	master	+43 -47

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDf9afaa3e40e1: Merge "Minor cleanup of ve.ui.MediaSizeWidget"

Event Timeline

Tchanders created this task.Oct 4 2018, 3:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2018, 3:57 PM

With the narrower inputs, there's no wrapping on a 320px-wide screen, and 4-digit numbers fit comfortably.

Change 464597 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Minor cleanup of ve.ui.MediaSizeWidget

https://gerrit.wikimedia.org/r/464597

gerritbot added a project: Patch-For-Review.Oct 4 2018, 4:02 PM

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Oct 5 2018, 5:41 PM

matmarex added a project: VisualEditor-MediaWiki-Mobile.

Change 464597 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Minor cleanup of ve.ui.MediaSizeWidget

https://gerrit.wikimedia.org/r/464597

Change 465294 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f9afaa3e4)

https://gerrit.wikimedia.org/r/465294

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Oct 8 2018, 11:25 PM

Change 465294 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f9afaa3e4)

https://gerrit.wikimedia.org/r/465294

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 9 2018, 12:00 PM

Jdforrester-WMF removed a project: Patch-For-Review.Oct 9 2018, 3:31 PM

Ryasmeen added a project: Verified.Oct 9 2018, 11:33 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Oct 10 2018, 8:56 PM

• Deskana closed this task as Resolved.Oct 11 2018, 3:07 PM

• Deskana triaged this task as Medium priority.

• Deskana added a project: Editing Q2 2018-19 mobile improvements.