Maniphest T206255

SpamBlacklist integration for JADE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	awight
	Oct 4 2018, 7:38 PM

Description

JADE will need to support the basic antivandalism extensions before we can deploy.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Tests to demonstrate SpamBlacklist integration	mediawiki/extensions/JADE	master	+118 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		awight	T206255 SpamBlacklist integration for JADE
		Resolved		awight	T206346 Support wikitext in judgment notes and endorsement comment fields

Event Timeline

awight created this task.Oct 4 2018, 7:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2018, 7:38 PM

Harej triaged this task as High priority.Oct 4 2018, 7:39 PM

Harej moved this task from Inbox to Feature Requests on the Jade board.

awight raised the priority of this task from High to Needs Triage.Oct 4 2018, 7:40 PM

awight updated the task description. (Show Details)

awight triaged this task as High priority.Oct 4 2018, 7:44 PM

As long as JADE is registering external links with ParserOutput in the standard way, there should be no extra changes needed for SpamBlacklist integration.

In T206255#4643497, @Legoktm wrote:

As long as JADE is registering external links with ParserOutput in the standard way, there should be no extra changes needed for SpamBlacklist integration.

Thanks for these breadcrumbs, I'll write a test to see whether it works out of the box.

Change 464727 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/JADE@master] [WIP] Tests for SpamBlacklist integration

https://gerrit.wikimedia.org/r/464727

gerritbot added a project: Patch-For-Review.Oct 4 2018, 10:06 PM

awight mentioned this in rEJADa22c017c5b0e: [WIP] Tests for SpamBlacklist integration.Oct 4 2018, 10:11 PM

So far, it's looking like we'll need to mess with ParserOutput hooks. I don't understand what's involved yet, only that we're in an awkward position with snippets of wikitext inside JSON fields. Maybe we can parse each snippet, extract the links and external links, then add to a top-level ParserOutput object?

awight added a subtask: T206346: Support wikitext in judgment notes and endorsement comment fields.Oct 5 2018, 5:43 PM

Normally this is done in Content::fillParserOutput(), which manipulates a ParserOutput object. I would assume that JADE is going to override that function whenever it implements a proper UI instead of relying on the JSON table output.

In T206255#4648568, @Legoktm wrote:

Normally this is done in Content::fillParserOutput(), which manipulates a ParserOutput object. I would assume that JADE is going to override that function whenever it implements a proper UI instead of relying on the JSON table output.

Thanks, it's helpful to have this confirmation! Let me invite you to the WIP patch where I'm trying to do this :-D
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/JADE/+/464737/

btw, someone recently pleaded with me to stop using Mustache, but I wasn't able to follow up to learn more. Maybe you can comment in code review if there's something better I should know about? This doesn't seem like a good use for OOUI, if that's the only alternative…

awight mentioned this in rEJADc5d23d25236f: [WIP] Tests for SpamBlacklist integration.Oct 8 2018, 7:31 AM

awight mentioned this in rEJADacdbc64bcb16: [WIP] Tests for SpamBlacklist integration.Oct 8 2018, 9:00 PM

awight mentioned this in rEJAD6f7fa88bcea3: [WIP] Tests for SpamBlacklist integration.Oct 9 2018, 7:29 PM

awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Oct 9 2018, 10:38 PM

awight mentioned this in rEJAD12b78fd5e6fa: Tests to demonstrate SpamBlacklist integration.Oct 9 2018, 10:39 PM

awight claimed this task.Oct 9 2018, 10:39 PM

awight mentioned this in rEJADc4f21224baae: Tests to demonstrate SpamBlacklist integration.Oct 10 2018, 3:28 PM

awight mentioned this in rEJAD47cabc4c50c3: Tests to demonstrate SpamBlacklist integration.Oct 11 2018, 10:15 PM

awight mentioned this in rEJAD80d874a94e56: Tests to demonstrate SpamBlacklist integration.Oct 12 2018, 7:54 PM

Harej moved this task from Feature Requests to Review on the Jade board.Oct 13 2018, 9:18 AM

awight mentioned this in rEJAD5523f3e1fcd3: Tests to demonstrate SpamBlacklist integration.Oct 16 2018, 4:36 AM

awight mentioned this in rEJAD81eeeaf6e6eb: Tests to demonstrate SpamBlacklist integration.