Page MenuHomePhabricator

Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException fails on PHP 7.1
Closed, ResolvedPublic

Description

19:18:07 1) Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException
19:18:07 ArgumentCountError: Too few arguments to function Wikibase\DataModel\Entity\Property::__construct(), 1 passed in /workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/mediawiki/View/FilePageMediaInfoViewTest.php on line 109 and at least 3 expected
19:18:07 
19:18:07 /workspace/src/vendor/wikibase/data-model/src/Entity/Property.php:60
19:18:07 /workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/mediawiki/View/FilePageMediaInfoViewTest.php:109
19:18:07 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/88/consoleFull

Event Timeline

Change 465123 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix incomplete Property constructor in FilePageMediaInfoViewTest

https://gerrit.wikimedia.org/r/465123

Change 465123 abandoned by Jforrester:
Fix incomplete Property constructor in FilePageMediaInfoViewTest

https://gerrit.wikimedia.org/r/465123

Jdforrester-WMF changed the task status from Open to Stalled.Oct 9 2018, 3:58 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Landed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/462743; remaining issues in the extension's test results are from T205958 and T206100, per @thiemowmde. Marking stalled until those are done and we can confirm it passes.

Legoktm assigned this task to thiemowmde.

Looking at the log in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/709/console I think we can confirm that this failure is gone now.