Page MenuHomePhabricator

TemplateData tests are failing on PHP 7.1
Closed, ResolvedPublic

Description

20:12:47 1) TemplateDataBlobTest::testParse with data set #22 (array('{\n					"description": "OHKeE...n				}', 'Data too large to save (75,22...5,535)'))
20:12:47 Status: Data too large to save (75,226 bytes, limit is 65,535)
20:12:47 Failed asserting that two strings are equal.
20:12:47 --- Expected
20:12:47 +++ Actual
20:12:47 @@ @@
20:12:47 -'Data too large to save (75,226 bytes, limit is 65,535)'
20:12:47 +'Data too large to save (75,227 bytes, limit is 65,535)'
20:12:47 
20:12:47 /workspace/src/extensions/TemplateData/tests/phpunit/TemplateDataBlobTest.php:660
20:12:47 /workspace/src/extensions/TemplateData/tests/phpunit/TemplateDataBlobTest.php:700
20:12:47 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
20:12:47 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/183/consoleFull

You can comment "check experimental" to trigger PHP 7.1 tests to verify the fix.

Related Objects

Event Timeline

Legoktm created this task.Oct 5 2018, 4:25 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 5 2018, 4:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 464852 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/TemplateData@master] TemplateDataBlobTest: Ensure identical results on PHP 7.1

https://gerrit.wikimedia.org/r/464852

Change 464852 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] TemplateDataBlobTest: Ensure identical results on PHP 7.1

https://gerrit.wikimedia.org/r/464852

Jdforrester-WMF closed this task as Resolved.Oct 5 2018, 6:37 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 5 2018, 6:38 PM

Change 467438 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/TemplateData@REL1_31] TemplateDataBlobTest: Ensure identical results on PHP 7.1

https://gerrit.wikimedia.org/r/467438

Change 467438 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@REL1_31] TemplateDataBlobTest: Ensure identical results on PHP 7.1

https://gerrit.wikimedia.org/r/467438