Page MenuHomePhabricator

ImageMetrics qunit test mw.imageMetrics.LoadingTimeLogger is failing
Closed, DeclinedPublic

Description

21:57:12   mw.imageMetrics.LoadingTimeLogger
21:57:12     ✖ No image, no logging
21:57:12       HeadlessChrome 0.0.0 (Linux 0.0.0)
21:57:12     logEvent was not called
21:57:12     Expected: 1
21:57:12     Actual: 0
21:57:12         at Object.<anonymous> (http://localhost:9876/load.php?debug=false&lang=en&modules=ext.eventLogging%2CimageMetrics%7Cext.eventLogging.subscriber%2Ctests%7Cext.imageMetrics.tests%7Cjquery%2Coojs%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.accessKeyLabel%2CcheckboxShiftClick%2Cclient%2Ccolor%2CcolorUtil%2Ccookie%2CgetAttrs%2Chidpi%2ChighlightText%2ClengthLimit%2Clocalize%2CmakeCollapsible%2CtabIndex%2Ctablesorter%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cmediawiki.ForeignApi%2CRegExp%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2Cinspect%2CjqueryMsg%2Clanguage%2CmessagePoster%2Cnotify%2Cstorage%2Ctemplate%2Ctoc%2Cuser%2Cutil%2Cviewport%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.language.months%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.rcfilters.filters.dm%7Cmediawiki.special.recentchanges%7Cmediawiki.template.mustache%2Cregexp%7Cmediawiki.widgets.MediaSearch%7Coojs-ui-core.styles%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cindicators%2Ctextures%7Cschema.ImageMetricsLoadingTime%7Ctest.mediawiki.qunit.suites%2Ctestrunner%7Ctest.sinonjs%7Cuser.defaults&skin=vector&version=1s5plco:15:987)
21:57:12         at runTest (node_modules/qunit/qunit/qunit.js:1774:30)
21:57:12         at Test.run (node_modules/qunit/qunit/qunit.js:1760:6)
21:57:12         at node_modules/qunit/qunit/qunit.js:1981:12
21:57:12         at advanceTaskQueue (node_modules/qunit/qunit/qunit.js:1373:6)
21:57:12         at advance (node_modules/qunit/qunit/qunit.js:1354:4)

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/345/console
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/19001/console

Event Timeline

I'd guess this extension is now owned by either Performance or Multimedia / Structured Data. If neither needs it, it should probably be undeployed.

I don't think Performance needs it. I've never seen or used it's metrics.

It was developed together with Mediaviewer if memory serves. @MarkTraceur Thoughts?

I forgot about that! Okay, let's do that then.

I forgot about that! Okay, let's do that then.

T240799: Archive the ImageMetrics extension.