Page MenuHomePhabricator

Remove wgContentTranslationHighMTCategory configuration
Closed, ResolvedPublic

Description

wgContentTranslationHighMTCategory was added in CX1 to set a category when the translation has machine translation greater than 75%(not configurable). The value of this configuration is a category.

But AFAIK there is no wiki that use this setting. CX2 replace this with section level machine translation usage and with a tracking category. See T190798: CX2: Add to a maintenance category when translation is published with too much unmodified text

So we can consider removing this setting.


What needs to be done

See T206307#10846765. Remove wgContentTranslationHighMTCategory configuration from puppet/modules/contenttranslation/manifests/wiki.pp file in mediawiki/vagrant repository.

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

@AkashKr_282 Are you still working on this task? Do you need help in getting started? Instructions are in the task description for what needs to be done.

Hype4shreshth claimed this task.

Hello sir i removed the previous assigned user because he claimed this task 10days ago.

Hello, I wanted to run the vagrant test suite (as detailed here) before making any changes related to this task, but I ran into quite a few problems.
I am on Macos 14.6.1 Sonoma.
The versions of multiple packages used in the testing suite (byebug, bundler) are older and require versions of ruby and the C compiler to match them.
I managed, after quite some trial and error, to get bundler to both install all the packages and run the testing script with the following: Ruby 2.6.10 (installed with rbenv) and clang from llvm@12.
llvm@12 is disabled by homebrew by default (14 is the oldest active) but it can still be installed by tapping homebrew/core, removing the disable line, installing with brew from the local copy, and then untapping core.

As of now all of the tests in the Rakefile run fine other than cucumber which is throwing the following error:

nicolasmichel•~/Documents/vagrant(master)» bundle exec rake cucumber                                                                                                                         [16:06:32]
/Users/nicolasmichel/.rbenv/versions/2.6.10/bin/ruby -S bundle exec cucumber -r tests/features tests/features
cannot load such file -- vagrant (LoadError)

The Rakefile and test/features directories are unchanged from master. Running the command with extra permissions does not help.
Please let me know if yall have any advice / pointers.

@Nicolasmichel Hi! Thanks for your interest in this task! After checking with a colleague, it looks like MediaWiki-Vagrant is unmaintained, so it may not be worthwhile to try getting it running. That said, fixing the file with the necessary changes is still valid and useful as part of this task. If you’re still interested, please go ahead with the requested changes in the task description. Thanks!

Hi! I'm interested in working on this task. @Hype4shreshth, are you still actively working on it? I don't see any recent patches submitted. If not, I'd love to pick it up. Thanks!

Hi, I am closing this as this ticket is quite old(7+ years) and much has changed in the codebase — making this ticket invalid.

What needs to be done

See T206307#10846765. Remove wgContentTranslationHighMTCategory configuration from puppet/modules/contenttranslation/manifests/wiki.pp file in mediawiki/vagrant repository.

This is not done. Easy to confirm with https://codesearch.wmcloud.org/search/?q=ContentTranslationHighMTCategory&files=&excludeFiles=&repos=.

Maybe better to remove all CX from vagrant?

Hi! I'd like to work on this task. Should I just remove wgContentTranslationHighMTCategory from puppet/modules/contenttranslation/manifests/wiki.pp, or should I remove all ContentTranslation configuration from vagrant as @Nikerabbit suggested? Happy to proceed once the scope is confirmed!

For this task, removing wgContentTranslationHighMTCategory and the related code and comments about category_keyword and high_mt_category is enough. That requires updating init.pp and wiki.pp.

Change #1251142 had a related patch set uploaded (by Reeti; author: Reeti):

[mediawiki/vagrant@master] contenttranslation: Remove wgContentTranslationHighMTCategory

https://gerrit.wikimedia.org/r/1251142

Hi! I've submitted a patch that removes wgContentTranslationHighMTCategory and its associated configuration from the ContentTranslation puppet manifests. By cleaning up the unused category_keyword and high_mt_category parameters from init.pp and wiki.pp, it keeps the configuration tidy and up to date.

Would appreciate any feedback!

Hi , it has been a long time since I submitted this patch, and it hasn't received any reviews yet. Could you please give some time to review this? I am fully open to your feedback and ready to make any necessary changes. Thank you!

Change #1251142 merged by Nikerabbit:

[mediawiki/vagrant@master] contenttranslation: Remove wgContentTranslationHighMTCategory

https://gerrit.wikimedia.org/r/1251142

Nikerabbit reassigned this task from Hype4shreshth to Reeti.
Nikerabbit removed a project: Patch-For-Review.
Nikerabbit added a subscriber: Hype4shreshth.