Steps to Reproduce
- https://en.m.wikipedia.org/ on a DESKTOP browser.
- Control-click an image
Expected Results
- Image opens in new tab just as it does for middle-clicking
Actual Results
- Image opens in the current tab and destroys browsing context
Environments Observed
- Production enwiki on Minerva
Browser Version
- Chromium 69.0.3497.81
OS Version
- Ubuntu v18.04
Device Model
- Desktop
Device Language
- English
Developer notes
Follow the logic of the MultimediaViewer extension: https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/master/resources/mmv.head/mmv.head.js#L38
Do not interfere with non-left clicks or if modifier keys are pressed.
QA steps
This can be tested on beta cluster or reading web staging (dev should confirm this and delete this parenthesises when this is done)
Things to double check
On mobile:
- Does clicking the image load the media overlay on mobile
- Can I use open image in new tab (hold press) without opening the image overlay
On desktop:
- Does clicking an image show the media overlay?
- Can I open an image in a new tab without opening the image overlay