Maniphest T206385

Pywikibot sets non-executable file's mode to 700
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Oct 6 2018, 9:29 AM

Description

Hi,

I figured out PWB automatically converts mode of user-password.py to 700 althrough 600 would be more appropriate,

See this example:

testovaci@notebook:~$ python ~/pywikibot/pwb.py login -family:species -lang:species
WARNING: /home/testovaci/pywikibot/pywikibot/tools/__init__.py:2015: UserWarning: File /home/testovaci/pywikibot/user-password.py had 600 mode; converted to 700 mode.
  warn(warn_str.format(filename, st_mode - stat.S_IFREG, mode))

Logging in to species:species as UrbanecmBot@BotTest
WARNING: /home/testovaci/pywikibot/pywikibot/tools/__init__.py:2015: UserWarning: File /home/testovaci/pywikibot/pywikibot.lwp had 664 mode; converted to 600 mode.
  warn(warn_str.format(filename, st_mode - stat.S_IFREG, mode))

Logged in on species:species as UrbanecmBot.

Martin

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[bugfix] Add a new variable 'private_folder_permission' to config.py	pywikibot/core	master	+28 -17
	Change default file mode for private files to 600	pywikibot/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T178061 Reduce (API) warning clutter in login.py after clean installation
Resolved		Urbanecm	T206385 Pywikibot sets non-executable file's mode to 700
Resolved	BUG REPORT	Xqt	T315045 Wrong permissions on created .pywikibot folder

Event Timeline

Urbanecm created this task.Oct 6 2018, 9:29 AM

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptOct 6 2018, 9:29 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript

Change 464943 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[pywikibot/core@master] Change default file mode for private files to 600

https://gerrit.wikimedia.org/r/464943

gerritbot added a project: Patch-For-Review.Oct 6 2018, 9:32 AM

Urbanecm triaged this task as Low priority.Oct 6 2018, 9:32 AM

Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.