Page MenuHomePhabricator

Big empty space under patch description
Closed, ResolvedPublic

Description

There is often a big, empty space between the patch description and the files section (circled in the example below). This is reduced if the browser window is wider, but it would be nice to have a more efficient layout even if you don't have it full screen.

Related Objects

StatusSubtypeAssignedTask
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedDzahn
Resolvedthcipriani
ResolvedAklapper
ResolvedAklapper
ResolvedQChris
ResolvedDzahn
ResolvedQChris
ResolvedQChris
Resolvedjcrespo
ResolvedDzahn
ResolvedPaladox
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedQChris
ResolvedBUG REPORTQChris
InvalidBUG REPORTNone
ResolvedDzahn
ResolvedBUG REPORTkostajh
ResolvedBUG REPORTQChris
ResolvedBUG REPORTQChris
InvalidBUG REPORTNone
ResolvedBUG REPORTQChris
OpenNone
InvalidNone
OpenNone
DuplicateBUG REPORTNone
OpenNone
ResolvedNikerabbit
DeclinedBUG REPORTNone
Resolvedhashar
InvalidNone
ResolvedQChris
DeclinedNone
OpenNone
DuplicateNone
DuplicateNone
ResolvedBUG REPORTQChris
ResolvedQChris
ResolvedQChris
DeclinedNone
OpenNone
ResolvedDzahn
OpenNone
ResolvedQChris

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2018, 9:44 AM

I'm sure @Paladox will know for sure, but looking at the new version, (as run by the developers of Gerrit) it appears that the relation chain (same topic/merge conflicts) will move below the commit message when the browser window is narrow.
Example: https://gerrit-review.googlesource.com/c/homepage/+/198954

Yup upstream I think fixed the white space I think on mobile devices.

Off-topic(-ish): I've noticed a lot of Tasks about PolyGerrit short coming's, that will be solved by newer releases of Gerrit, helpfully answered by @Paladox. Whenever WMF switches to the new version of Gerrit (T205784), we can close those tasks by the dozen. Is it helpful to move those tasks to a separate column on Gerrit so we can clearly indicate that they are issues solved when we switch to the new version and close them all at once?

We could add a “PolyGerrit fixed board”.

Note that T205784 will not fix this, rather T200739 will.

Paladox moved this task from PolyGerrit to Maybe fixed? on the Gerrit board.Oct 8 2018, 4:05 PM

Change 609519 had a related patch set uploaded (by QChris; owner: Christian Aistleitner):
[operations/puppet@production] gerrit: Add table for Zuul CI results underneath the commit message

https://gerrit.wikimedia.org/r/609519

Change 609519 merged by Dzahn:
[operations/puppet@production] gerrit: Add table for Zuul CI results underneath the commit message

https://gerrit.wikimedia.org/r/609519

QChris closed this task as Resolved.Jul 11 2020, 7:36 PM
QChris claimed this task.
QChris added a subscriber: QChris.

Since this empty space is now filled with results from CI jobs (T256575), I'm boldly closing.