Page MenuHomePhabricator

Duplicate names $wgAddGroups et al should be removed not to confuse Special:ListGroupRights display
Closed, ResolvedPublic

Description

From meta, rights assigned to the bureaucrats:

  1. Can add groups: IP block exemptions, Bots, Administrators, Bureaucrats, Administrators, Bureaucrats and Bots
  2. Can remove groups: Bots, Administrators, Bureaucrats, IP block exemptions, Flood flag and Bots

From plwiki:

http://pl.wikipedia.org/wiki/Specjalna:Uprawnienia_grup_u%C5%BCytkownik%C3%B3w?uselang=en

  1. Can add groups: Abuse filter editors, Administrators, Bureaucrats, Bots, Administrators, Bureaucrats, Bots and Reviewers
  2. Can remove groups: Abuse filter editors, Bots, Bots and Reviewers

Looks like $wgAddGroups['bureaucrat'], $wgRemoveGroups['bureaucrat'] settings:

http://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php

should be truncated not to include the defaults OR Special:ListGroupRights page should remove duplicate group names on display.

for example:

'+plwiki' => array(
    'bureaucrat' => array( 'abusefilter', 'sysop', 'bureaucrat', 'bot' ),
),

does no longer need ('sysop', 'bureaucrat', 'bot') elements due to the default.


Version: unspecified
Severity: major
URL: http://meta.wikimedia.org/wiki/Special:ListGroupRights?uselang=en

Details

Reference
bz18648

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:35 PM
bzimport set Reference to bz18648.
bzimport added a subscriber: Unknown Object (MLST).

Special:ListGroupRight should just filter duplicate entries (using array_unique()) before displaying those lists.

  • Bug 18741 has been marked as a duplicate of this bug. ***

Adds an array_unique function to the array of user groups

patch included.

Attached:

  • This bug has been marked as a duplicate of bug 19301 ***