Page MenuHomePhabricator

The syntax highlight dialog's Apply changes action is enabled and disabled erratically
Closed, ResolvedPublic


Examples of erratic behaviour:

  • The action is enabled when the dialog is first opened, before any changes are made
  • The action is disabled when the language input is invalid BUT is enabled again if a change is made to the code input, even though the language input is still invalid

The second example means it's actually possible to save an invalid lang attribute.

Event Timeline

Change 465198 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update syntax highlight dialog actions consistently

TheDJ triaged this task as Medium priority.Oct 9 2018, 6:29 AM
TheDJ added a project: SyntaxHighlight.

Change 465198 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update syntax highlight dialog actions consistently

Hmm, I don't have permission to edit this task. Wonder why? Unable to add Verify tag therefore.

Nevermind, got resolved magically!