Page MenuHomePhabricator
Create Task
Maniphest T206481

The syntax highlight dialog's Apply changes action is enabled and disabled erratically
Closed, ResolvedPublic
Actions

Description

Examples of erratic behaviour:

  • The action is enabled when the dialog is first opened, before any changes are made
  • The action is disabled when the language input is invalid BUT is enabled again if a change is made to the code input, even though the language input is still invalid

The second example means it's actually possible to save an invalid lang attribute.

Details

SubjectRepoBranchLines +/-
Update syntax highlight dialog actions consistentlymediawiki/extensions/SyntaxHighlight_GeSHimaster+16 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Oct 8 2018, 5:44 PM
gerritbot subscribed.Oct 8 2018, 5:49 PM

Change 465198 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update syntax highlight dialog actions consistently

https://gerrit.wikimedia.org/r/465198

gerritbot added a project: Patch-For-Review.Oct 8 2018, 5:49 PM
TheDJ triaged this task as Medium priority.Oct 9 2018, 6:29 AM
TheDJ added a project: SyntaxHighlight.
gerritbot added a comment.Oct 9 2018, 8:01 PM

Change 465198 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update syntax highlight dialog actions consistently

https://gerrit.wikimedia.org/r/465198

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Oct 9 2018, 8:04 PM
• iamjessklein awarded a token.Oct 9 2018, 8:28 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 9 2018, 9:00 PM
Ryasmeen subscribed.Oct 9 2018, 11:53 PM

Hmm, I don't have permission to edit this task. Wonder why? Unable to add Verify tag therefore.

Ryasmeen added a project: Verified.Oct 9 2018, 11:53 PM

Nevermind, got resolved magically!

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Oct 10 2018, 8:56 PM
• Deskana closed this task as Resolved.Oct 11 2018, 3:04 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2018, 3:04 PM
matmarex mentioned this in T206000: Apply changes action is enabled on several dialogs before any changes are made.Nov 15 2018, 2:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL