Page MenuHomePhabricator

Standardize navigation and adjust naming of pages
Closed, ResolvedPublic5 Estimated Story Points

Description

As we add more data and reports to Grant Metrics, we need to make some changes to navigation and page naming in order to a) make the names of pages more distinct, so that they aren't confusing, b) to implement and standardize navigation among the pages, and c) to provide the full complement of downloadable reports from relevant pages.

This must happen before we release the first of the new downloadable reports. On the Event Summary and Settings pages, these navigation changes will happen before the pages have reached their final designs. This should present no problem, though for Edit Summary an " interim"design is shown below for clarity.

Here are the new, official names of the three main Event pages in the system:

NEW NameOLD name
Event summaryno old name
Edit listEvent data
Event settingsEdit event

Here is a diagram that shows the navigation flows. For each screen, every possible destination and link should be accounted for, which should make this useful for design and QA.

Event Metrics Navigation, with breadcrumbing.png (1×1 px, 78 KB)

Changes to 'Edit list' page

  • Redesign the page name to be consistent with the naming of all event pages, which are in the format: Pagename / Eventname
    • New name of this page is: Edit list
  • Add button at top-right to take users to the "Settings" page
  • Remove the "Download csv" and "Download wiki table" links.
  • Replace those buttons with the new 'Download reports' button (menu defined in T206576)
  • And add the "last updated" notation (as on the Event Summary page)
  • Change name in breadcrumbing from "Event data" to "Edit list"
Existing pagePage with new navigation and naming
Screen Shot 2018-10-08 at 1.38.33 PM.png (622×1 px, 156 KB)
Screen Shot 2018-10-30 at 8.08.15 PM.png (1×2 px, 479 KB)

Changes to the 'Event summary' page

  • Redesign the page name to be consistent with the naming format: Pagename / Eventname
    • New name of this page is: Event summary
  • Fonts:
    • Page name is in Roboto, uppercase, small-caps, size is 12px, weight is 500.
    • Event name is in Roboto, size is 36px, weight is 800
  • Change "View all data" button to "View edit list" button (for interim design); see mockups for positioning, which is different for the interim and final designs.
  • Remove the "Edit event" link and replace with a "Settings" button
  • Add the new 'Download reports' button (menu defined in T206576)
  • Temporarily make the Download Reports button unavailable on this page until we can incorporate some other reports and get the menu working (at which point we'll bring the button back).
Existing pageInterim pg with old design but new navigationfinal page with new design and navigation
Event data screen, Grant Metrics.png (945×1 px, 148 KB)
eventsummary-interim.png (1×2 px, 346 KB)
eventsummary.png (1×2 px, 454 KB)

Changes to the 'Event settings' page

  • Redesign the page name to be consistent with the naming format: Pagename / Eventname
    • New name of this page is: Event settings
Existing pagePage with new navigation and naming
Event setup screen, Grant Metrics.png (808×1 px, 92 KB)
Screenshot_2018-10-25 Name of Event - Grant Metrics(1).png (1×2 px, 301 KB)

(Don't worry in this ticket about the other changes to the Settings page pictured here, which are covered in T206483)

Event Timeline

Prtksxna updated the task description. (Show Details)
jmatazzoni renamed this task from Create standard navigation / toolbar and adjust naming of pages to Standardize navigation and adjust naming of pages.Oct 25 2018, 5:54 PM
jmatazzoni updated the task description. (Show Details)

Small design tweaks, 10/25

@Prtksxna, thanks for adding the screenshots. I'm going through this one more time so I can get it estimated, and caught a few things. Please make the following changes.

Edit summary screen

  • Please add a new design for the Event Summary page to show it during the "interim" period, where we've changed the navigation but haven't yet changed the data and overall page design. I left a place for it in the Description, above.

Edit list screen

  • Need an "Update totals" button on this page, I now see. (I'm not sure why it was not there before, but with the Download menu it is definitely necessary).
  • Also please add the "last updated..." anotation to the screen.

All screens, naming

  • Update totals Is there a reason why we changed "Update data" to "Update totals"? They seem about the same to me, so I'm OK with it. But on the other hand we shouldn't change things if we don't have a good reason, since this name is probably used in Help docs etc. . If that wasn't intentional, then maybe change it back. Ping me with your decision, since the text of the Description now matches your mocks.
  • Settings I did say we could drop the "Event" from the settings button. But I think I may have forgotten that on the Program pages, there is currently an "edit program" link. So we're heading down a road that will bring us to a place where two buttons with the same name will take you to two different pages/toolsets. What is your thought about that?

Edit list screen

  • Also please add the "last updated..." anotation to the screen.

There is a last updated annotation in the text below. I'd like to move it up (closer to the buttons, as it is on the summary page), but we had decided we don't want to touch the content of that page at all so we let it stay there. Happy to move it up and remove it below if you're fine with that.

All screens, naming

  • Update totals Is there a reason why we changed "Update data" to "Update totals"? They seem about the same to me, so I'm OK with it. But on the other hand we shouldn't change things if we don't have a good reason, since this name is probably used in Help docs etc. . If that wasn't intentional, then maybe change it back. Ping me with your decision, since the text of the Description now matches your mocks.

Changed it back to Update data, I don't know why we changed it. Maybe on oversight?

  • Settings I did say we could drop the "Event" from the settings button. But I think I may have forgotten that on the Program pages, there is currently an "edit program" link. So we're heading down a road that will bring us to a place where two buttons with the same name will take you to two different pages/toolsets. What is your thought about that?

If I remember correctly, we did discussed the following: different aspects of a UI has different settings, and users already have an understanding that the settings (buttons) are for the object that they're looking at. For example, a settings button on a Facebook album, and a settings button on a profile page does different things.

In T206495#4701068, @Prtksxna wrote:

Edit list screen

  • Also please add the "last updated..." anotation to the screen.

There is a last updated annotation in the text below. I'd like to move it up (closer to the buttons, as it is on the summary page), but we had decided we don't want to touch the content of that page at all so we let it stay there. Happy to move it up and remove it below if you're fine with that.

yes, please move it up to be with the buttons, as on other pages. Thanks. Moving this for estimation.

@Prtksxna pls add design specs for changed naming, etc.

PR: https://github.com/wikimedia/eventmetrics/pull/145

I took the liberty of applying the same styling changes to the other pages, just to keep them all consistent. I've got it deployed at https://eventmetrics-dev.wmflabs.org. @Prtksxna Let me know what you think! However note that the "Edit List" page is currently broken until https://github.com/wikimedia/eventmetrics/pull/143 is merged.

Some things feel a little off, like using the large bolden font for "Create an event". I think it's okay?

Also, I went by the mock up shown above that has the top-right buttons ordered like so:

Screen Shot 2018-10-30 at 8.08.15 PM.png (1×2 px, 479 KB)

while the mockup at T206576 has:

Screen Shot 2018-10-09 at 2.08.10 PM.png (291×429 px, 35 KB)

Personally I prefer the latter, where "Download options" is a normal button in the middle, and the "Update totals" is the primary blue-coloured button on the right (since that button makes changes to the data).

I took the liberty of applying the same styling changes to the other pages, just to keep them all consistent. I've got it deployed at https://eventmetrics-dev.wmflabs.org. @Prtksxna Let me know what you think! However note that the "Edit List" page is currently broken until https://github.com/wikimedia/eventmetrics/pull/143 is merged.

Whoa! Thank you for making these changes 😊

Some things feel a little off, like using the large bolden font for "Create an event". I think it's okay?

You're right, that shouldn't be bold — https://prtksxna.github.io/wmf-prototype-gm/new-event.html

while the mockup at T206576 has:

Screen Shot 2018-10-09 at 2.08.10 PM.png (291×429 px, 35 KB)

This seems like an outdated version. Where are you seeing this (I should fix it)? The the dev link that you shared has the correct intended ordering.

Some things feel a little off, like using the large bolden font for "Create an event". I think it's okay?

You're right, that shouldn't be bold — https://prtksxna.github.io/wmf-prototype-gm/new-event.html

Okee doke, this is now fixed and can be viewed on https://eventmetrics-dev.wmflabs.org

I completely forgot about https://prtksxna.github.io/wmf-prototype-gm/. It is very helpful!

The other thing I did (before revisiting your prototype) was make program pages look like the event page, with the page title "Event list", e.g.:

Screen Shot 2018-11-26 at 15.36.02.png (219×335 px, 22 KB)

And similarly for "Program settings":

Screen Shot 2018-11-26 at 15.37.49.png (252×351 px, 27 KB)

Not sure if we really want that or not.

while the mockup at T206576 has:
F26448689

This seems like an outdated version. Where are you seeing this (I should fix it)? The the dev link that you shared has the correct intended ordering.

Hmm, obviously not at T206576. I don't know where I saw it!

@MusikAnimal, should I move to Product/QA Review? Or are you still working on it?

@MusikAnimal, should I move to Product/QA Review? Or are you still working on it?

I wanted to get a design/product sign-off before merging the code. Everything is on https://eventmetrics-dev.wmflabs.org. I don't know which column makes the most sense in this case, since we usually merge the code first (maybe we shouldn't).

@MusikAnimal, this is looking good. I checked everything above off except for two items:

  • I'll let @Prtksxna confirm that the fonts/design is correct (though it looks right to me).
  • The "View all data" button needs to be renamed "View edit list". (You did just what we said but what we told you was wrong: since we renamed the page, we should go ahead and rename the button, to be consistent in all places.)

When you've completed those, please put back in the QA/Product column

The "View all data" button needs to be renamed "View edit list".

Done. I'll move back to "Needs Review/Feedback" for a design signoff.

@MusikAnimal, I'm bouncing this back to Development for one last thing— sorry to keep adding new requirements! But in the meeting yesterday I realized that if this goes to production ahead of some of the functionality it was designed to accompany we'll have a small UI problem. Namely, a user is on the Event Summary page who asks to "Download reports" from the new button will naturally expect that she will download the Event Summary report. But she won't—she'll get the Edit List report, since it is the only one currently available.

The solution here is to temporarily make the Download Reports button unavailable on this page until we can incorporate some other reports and get the menu working, at which point we'll bring the button back.

You can either put the button into the gray, unavailable state. Or you could just comment it out or whatever to make it disappear. Your call.

@MusikAnimal, I'm bouncing this back to Development for one last thing— sorry to keep adding new requirements! But in the meeting yesterday I realized that if this goes to production ahead of some of the functionality it was designed to accompany we'll have a small UI problem. Namely, a user is on the Event Summary page who asks to "Download reports" from the new button will naturally expect that she will download the Event Summary report. But she won't—she'll get the Edit List report, since it is the only one currently available.

The solution here is to temporarily make the Download Reports button unavailable on this page until we can incorporate some other reports and get the menu working, at which point we'll bring the button back.

You can either put the button into the gray, unavailable state. Or you could just comment it out or whatever to make it disappear. Your call.

There are still two reports to download, no? I'm not sure current users will be confused, since the options are the same as they always have been. Before they had two separate buttons, and now they're nested in a dropdown. In the future, we'll merely be putting additional links in this dropdown (or replacing existing ones, not sure), right?

If the word "report" is the concern, maybe we can just change the button text to "Download". How does that sound?

In T206495#4783569, @MusikAnimal wrote:

....There are still two reports to download, no? I'm not sure current users will be confused, since the options are the same as they always have been.

They are not the same because in the past there was no report you could download from the Event Summary page. The only report on offer was the Edit List, which you could get only from the Edit List page. Please leave that page just as it is; the dropdown works just fine there. The ask here is to gray out the Download button on the Event Summary page only.

In T206495#4783569, @MusikAnimal wrote:

....There are still two reports to download, no? I'm not sure current users will be confused, since the options are the same as they always have been.

They are not the same because in the past there was no report you could download from the Event Summary page. The only report on offer was the Edit List, which you could get only from the Edit List page. Please leave that page just as it is; the dropdown works just fine there. The ask here is to gray out the Download button on the Event Summary page only.

Got it, that makes perfect sense. I'm going to go with hiding the dropdown entirely on the Event Summary page, which I think you said was acceptable. That will make it the same as things are now in production.

In T206495#4783987, @MusikAnimal wrote:

...'m going to go with hiding the dropdown entirely on the Event Summary page, which I think you said was acceptable.

Yep, that will be good—just make it so it's easy to bring it back.

Can this be closed?

I think so but let me go through it tomorrow.

jmatazzoni moved this task from QA to Q2 2018-19 on the Community-Tech-Sprint board.

OK looks good. Closing this task. Thanks Leon.