Maniphest T206518

Add wikibase-termbox to Wikibase
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jakob_WMDE
	Oct 9 2018, 10:13 AM

Description

add the repo as a submodule to Wikibase
register termbox as a resource loader module
make request to external node service and render in place of the termbox
add a feature flag that is disabled by default
- prevents resource loader module being loaded
- prevents server side rendering request

Details

	Subject	Repo	Branch	Lines +/-
	Load the dist files from wikibase-termbox	mediawiki/extensions/Wikibase	master	+7 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lea_WMDE	T205260 Change styling of label, description and aliases of interface language
Resolved	Lea_WMDE	T206200 Showcase a termbox placeholder in the mobile frontend of m.wikidata.org
Resolved	None	T206518 Add wikibase-termbox to Wikibase

Event Timeline

Jakob_WMDE triaged this task as Medium priority.Oct 9 2018, 10:13 AM

Jakob_WMDE created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2018, 10:13 AM

• Matthias_Geisler_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration1 board.Oct 9 2018, 4:15 PM

Change 465446 had a related patch set uploaded (by Addshore; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] Register new termbox to wikibase and add feature flag

https://gerrit.wikimedia.org/r/465446

gerritbot added a project: Patch-For-Review.Oct 10 2018, 8:56 AM

Addshore moved this task from incoming to in progress on the Wikidata board.Oct 11 2018, 8:41 AM

Change 466933 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Load the dist files from wikibase-termbox

https://gerrit.wikimedia.org/r/466933

Lea_WMDE added a project: Wikidata-Termbox-Iteration-2.Oct 17 2018, 9:09 AM

Lea_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-2 board.Oct 17 2018, 9:11 AM

Change 466933 abandoned by Jakob:
Load the dist files from wikibase-termbox

Reason:
Done as part of Id127dc87348d30ff011a32760038fbc74335da1e

https://gerrit.wikimedia.org/r/466933

Lea_WMDE added a project: Wikidata-Termbox-Iteration-3.Oct 31 2018, 9:45 AM

Lea_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-3 board.

Jakob_WMDE closed this task as Resolved.Nov 9 2018, 10:26 AM

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-3 board.