Page MenuHomePhabricator

"Soft" actions shouldn't be logged if the edit isn't saved
Open, Needs TriagePublic

Description

If you have a filter set to "disallow", and another set to "tag" (probably it's fine if they're bot in the same filter too, although it doesn't make sense) and an edit triggers both filter, the edit is disallowed as expected. However, the abuselog for the tagging filter will show "Actions taken: Tag". However, since the edit wasn't saved, no tag has been applied and thus it's quite confusing to see it. What we should probably do is, check if the edit will be disallowed (which can also happen with other blocking options), and if any of these is triggered, unset any "soft" consequence (probably only tag?). This should be easier to do after T204447.

Event Timeline

Change 466674 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Remove "soft" actions when the edit will be disallowed.

https://gerrit.wikimedia.org/r/466674

Change 466674 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Remove "soft" actions when the edit will be disallowed.

https://gerrit.wikimedia.org/r/466674

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)