Page MenuHomePhabricator

Abuse filter log: 'details' and 'examine' redundant
Open, LowestPublic

Description

Author: matthew.britton

Description:
As far as I can see, the only difference between the "details" and "examine" links in the abuse filter log are that the "details" link shows the log entry and a diff of the change, whereas "examine" does not. Both have a listing of the variables for that action. Are separate links really necessary?


Version: unspecified
Severity: minor

Details

Reference
bz18655

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:36 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz18655.
bzimport added a subscriber: Unknown Object (MLST).

'examine' also includes an interface for testing a filter against a change.

matthew.britton wrote:

(In reply to comment #1)

'examine' also includes an interface for testing a filter against a change.

True, but that interface isn't shown when following the 'examine' link on a log entry, only when going to [[Special:AbuseFilter/examine]].

I'm not suggesting getting rid of that interface entirely, just not showing the 'examine' link on log entries.

mike.lifeguard+bugs wrote:

(In reply to comment #1)

'examine' also includes an interface for testing a filter against a change.

Then why have /details if it's the same only minus a feature?

matthew.britton wrote:

(In reply to comment #3)

Then why have /details if it's the same only minus a feature?

"Details" shows the log entry and a diff of the change, as well as the listing of variables for that action. "examine" only has the list of variables (and the interface for testing a filter, when accessed through [[Special:AbuseFilter/examine]].

Both are useful. However *in the log* the "examine" link doesn't add anything that the "details" one doesn't. This bug is only about dropping one of those links to aid usability. Dropping the "details" one would be the wrong thing to do as the diff is a pretty essential piece of information, so the "examine" one should be dropped.

Marking this bug as Lowest priority.

I've done this in a batch to (usually enhancement request) bugs where:

  • It is not clear that this bug should be fixed.
  • It is not clear how to fix this bug.
  • There are difficulties or complications in fixing this bug, which are not justified by the importance of the bug.
  • This is an extremely minor bug that could not be fixed in a few lines of code.

If you're interested in having one of these bugs fixed, your best bet is to write the patch yourself.

Extremely old, but gerrit change I0985352d.

https://gerrit.wikimedia.org/r/38716 (Gerrit Change I0985352d4e9e5d076df42d16d9a291d637715c4e) | change ABANDONED [by Legoktm]

Amire80 moved this task from Backlog to Logging on the AbuseFilter board.May 8 2016, 9:03 AM
Thryduulf removed a subscriber: Thryduulf.
Thryduulf added a subscriber: Thryduulf.