| • alexhollender_WMF | |
| Oct 9 2018, 5:40 PM |
| F26573436: image.png | |
| Oct 13 2018, 12:51 AM |
| F26569423: edit-dropdown.jpg | |
| Oct 12 2018, 9:38 PM |
| F26569144: Screen Shot 2018-10-12 at 5.19.28 PM.png | |
| Oct 12 2018, 9:23 PM |
| F26569182: Screen Shot 2018-10-12 at 5.19.07 PM.png | |
| Oct 12 2018, 9:23 PM |
| F26569166: Screen Shot 2018-10-12 at 5.18.54 PM.png | |
| Oct 12 2018, 9:23 PM |
| F26569154: Screen Shot 2018-10-12 at 5.19.39 PM.png | |
| Oct 12 2018, 9:23 PM |
| F26446075: Artboard.png | |
| Oct 9 2018, 5:40 PM |
The button label is always "Edit" (regardless of which editor you're about to enter)
once you click "Edit" the button label switches to "Edit this page"
I would like to hear more about this case, because I've never seen it, and it seems like a bug. Can you load the page with ?uselang=qqx (see https://mediawiki.org/wiki/qqx) to reveal which localisation message generates this text?
The rest of the behavior you describe is intentional (I have no opinion on whether we should change it). A link always says "Edit" if it's going to open the visual editor, and always says "Edit source" if it's going to open the wikitext editor. This is consistent in single-tab and multi-tab mode, and with section edit links as well.
Thanks for posting this @alexhollender - From my perspective, the interaction is Edit (no matter if you are in Wikitext or Visual Editor). Then, the second level of interaction is choosing how you want to edit. For consistency the buttons should say the exact same thing and never change.
Can you load the page with ?uselang=qqx (see https://mediawiki.org/wiki/qqx) to reveal which localisation message generates this text?
| before clicking "Edit" | after clicking "Edit" | |
| normal |  |  |
| ?uselang=qqx |  |  |
I agree with @iamjessklein that it would make sense for the button to always say "Edit", regardless of the editor experience you're about to get. I don't feel like the benefit of knowing which editor experience you're about to get (which is hard to articulate) outweighs the potential confusion from the button having different labels. I do, however, find it annoying to switch to my desired mode once I am inside the editing experience so depending on how often average editors switch between editing experiences it could be worth exploring having a dropdown next to the edit button that would allow you to directly access the mode you want (i.e. the non-default one for a respective user):
@alexhollender Thank you, that's very helpful. I was able to find where we use the incorrect localisation message ( 'edit' instead of 'vector-view-edit'). I filed T206892 with some more details about this. Let's make this task just about the 'Edit' vs 'Edit source' distinction.
I agree with @iamjessklein that it would make sense for the button to always say "Edit", regardless of the editor experience you're about to get. I don't feel like the benefit of knowing which editor experience you're about to get (which is hard to articulate) outweighs the potential confusion from the button having different labels. I do, however, find it annoying to switch to my desired mode once I am inside the editing experience so depending on how often average editors switch between editing experiences it could be worth exploring having a dropdown next to the edit button that would allow you to directly access the mode you want (i.e. the non-default one for a respective user):
We already have a preference for your use case: on https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-editing, set "Editing mode" to "Show me both editor tabs". Then you will get two tabs, "Edit" and "Edit source", side-by-side:
This was actually the only available option at the beginning when VisualEditor was introduced; the single-edit-tab modes were added later. Possibly we kept the distinction in single-edit-tab mode for familiarity to users who used the multi-tab mode previously? Alas, I wasn't on the team yet when this was being changed.